public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: rockchip_sdhci: add clock init for mmc
Date: Mon, 10 Oct 2016 14:40:11 +0800	[thread overview]
Message-ID: <57FB37CB.2060405@rock-chips.com> (raw)
In-Reply-To: <606545aa-cde3-70f4-e6b6-18927939bbf4@samsung.com>

Hi Jaehoon,

On 10/10/2016 07:01 AM, Jaehoon Chung wrote:
> On 10/07/2016 06:23 PM, Kever Yang wrote:
>> Init the clock rate to CONFIG_ROCKCHIP_SDHCI_MAX_FREQ with clock driver
>> api.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>   drivers/mmc/rockchip_sdhci.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
>> index c56e1a3..e787343 100644
>> --- a/drivers/mmc/rockchip_sdhci.c
>> +++ b/drivers/mmc/rockchip_sdhci.c
>> @@ -12,6 +12,7 @@
>>   #include <libfdt.h>
>>   #include <malloc.h>
>>   #include <sdhci.h>
>> +#include <clk.h>
>>   
>>   /* 400KHz is max freq for card ID etc. Use that as min */
>>   #define EMMC_MIN_FREQ	400000
>> @@ -33,7 +34,10 @@ static int arasan_sdhci_probe(struct udevice *dev)
>>   	struct rockchip_sdhc *prv = dev_get_priv(dev);
>>   	struct sdhci_host *host = &prv->host;
>>   	int ret;
>> +	struct clk clk;
>>   
>> +	ret = clk_get_by_index(dev, 0, &clk);
> What purpose do you use "ret" value?

Forgot to do the error check with 'ret', will add it at V2.

Thanks,
- Kever
>
> Best Regards,
> Jaehoon Chung
>
>> +	clk_set_rate(&clk, CONFIG_ROCKCHIP_SDHCI_MAX_FREQ);
>>   	host->quirks = SDHCI_QUIRK_WAIT_SEND_CMD;
>>   
>>   	ret = sdhci_setup_cfg(&plat->cfg, host, CONFIG_ROCKCHIP_SDHCI_MAX_FREQ,
>>
>
>
>

      reply	other threads:[~2016-10-10  6:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161007092411epcas1p431c3976e72dd78d2def7b9afde578d02@epcas1p4.samsung.com>
2016-10-07  9:23 ` [U-Boot] [PATCH] mmc: rockchip_sdhci: add clock init for mmc Kever Yang
2016-10-09 23:01   ` Jaehoon Chung
2016-10-10  6:40     ` Kever Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57FB37CB.2060405@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox