[U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

[Patrick DELAUNAY <patrick.delaunay@st.com>]

Hi Urja,

> 
> Hi,
> 
> On Thu, May 16, 2019 at 7:44 AM Patrick DELAUNAY
> <patrick.delaunay@st.com> wrote:
> >
> > Hi Urja,
> >
> > > -     if (type != SYSRESET_POWER)
> > > +     if (type != SYSRESET_POWER_OFF)
> > >               return -EPROTONOSUPPORT;
> >
> > In fact in the next part of the code, we are supporting only
> > SYSRESET_POWER (reset with PMIC1 switch OFF and restart) and not
> > SYSRESET_POWER_OFF....
> >
> > because Power Cycle if RREQ_EN=1
> >
> > I think you need to remove the update on this file for your patch and
> > I will modified this function is to support both mode....
> Okay I will drop this part, but just to confirm... this means that currently you have
> a configuration where using the poweroff command causes a power-cycle? Neat.

Yes and it was stange.

I choose it at the beginning of the project because for some hardware
configuration with STPMIC1, the VDD continue to be provided by the cell even 
if the power supply is still present in power off mode; HW team ask me to avoid this case,
to avoid the cell usage.

But it is more a workaround for the bad HW configuration, and I forget this point when I upstream the driver...

Your patch allow me to correct this point now (with http://patchwork.ozlabs.org/patch/1101856/) and
I come back to a normal behavior in the driver : driver execute the requested command.

Regards
Patrick

> --
> Urja Rannikko