From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 17 Jul 2020 11:57:13 +0200 Subject: [PATCH v1 1/4] usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) In-Reply-To: References: <20200702084733.2032531-1-sr@denx.de> <20200702084733.2032531-2-sr@denx.de> Message-ID: <57f6d58b-7773-1070-bc6a-00a5b9ae6165@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 17.07.20 07:15, Bin Meng wrote: > On Thu, Jul 2, 2020 at 4:47 PM Stefan Roese wrote: >> >> While trying to use the U-Boot xHCI driver on the MIPS Octeon platform, >> which is big endian, I noticed that the driver is missing a few endian >> conversion calls. This patch adds these missing endian conversion >> calls. >> >> Signed-off-by: Stefan Roese >> Cc: Bin Meng >> Cc: Marek Vasut >> --- >> >> drivers/usb/host/xhci-mem.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> > > Good catch! It's hard to detect these problems if we only validate > xHCI on ARM/x86 which are little-endian. Apparently there is no xHCI > on PPC, so MIPS becomes the first big endian platform using xHCI. Yes, I was also astonished that the xHCI driver has only been used by little-endian platforms so far. I did expect that at least some PPC platforms supported this code. Apparently this is not the case. > Reviewed-by: Bin Meng Thanks, Stefan