From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 500A2C43334 for ; Tue, 14 Jun 2022 21:01:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CEC7F8435C; Tue, 14 Jun 2022 23:01:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nxpNgDUA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB85984395; Tue, 14 Jun 2022 23:01:29 +0200 (CEST) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 604ED84347 for ; Tue, 14 Jun 2022 23:01:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x62e.google.com with SMTP id m20so19447583ejj.10 for ; Tue, 14 Jun 2022 14:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/shwbDF0t8cNux/TD5y6bDuvIPOP+LQ0wXUaj+pYBLU=; b=nxpNgDUAOFSLDIP3qGyNosOvoQYh5c7e5AZC1CTfbWsxKBRVn8J5VJz929ja8MNm0i zS2KWqA5raMTzEpyrff1oz5eN9N4IT2XMofBOWwYB1Br9OmYzDkq32M+wbTrE84MhSCu +vHBy1dmK7Ng3duUw6fLSivB8e/h+TLn3AjWegxbe4+tkJ85sJk6VnX8+DhZjrbaN2Oa Jeqa0Zv1Xpb1WSX0QPE4ZSujxB+d5bvv/TiVvYhwBS5KaNs/T3wjT4iolprxscWecTJ4 owrQyqSAkxp60TiJsBVl9w26kDsL17S4G23B3zUf68PMhvNvai/qFE35CKPR1J1TcEGy A26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/shwbDF0t8cNux/TD5y6bDuvIPOP+LQ0wXUaj+pYBLU=; b=a3goZaxpvQb6sTQNrk+sOgv+TtRtt8PjTtCknUjtGVFn1h73f2jj1BOf5RSLnnS4/a tKfiASjwdmhMPiKmFRoA4G4C+t9pOCM6ErW1nW70T5h580moPsh1M0uJrRCE55kDhbrc 1xjv6yitgA2Io45bHvbyS84R2ifPDi1YFJEG7mkbmQ4pGnpWh1wZMMOssx1wUGYwzsun 6zxvZR4POyI0/Faa99Obp+liHwWCVi/6mUNW72uDVxyJ/4KGzTgpZwztSB/ct/V75cEo L6Gv11bhNwagCFJfY6Qg3KkTTYHe87yLPzJaXVNqjlrUjS8t3Au8sKLZ/+BE4TVdwYzI lKkw== X-Gm-Message-State: AOAM531yQdly+zOfUYkwtXMMqKWrfsSuAcpOm67COprfhkQIcoxfXOTp w8WPlgedsC9lxHHwziO6z7A= X-Google-Smtp-Source: ABdhPJzwSN+XdsNaRfD8plsFKlAXmn0Ip31OIc0o7z5jIrYsWXs5eYh9ozrzm1xgFuugqHJtQeZVCA== X-Received: by 2002:a17:906:804a:b0:70c:1dac:9bb8 with SMTP id x10-20020a170906804a00b0070c1dac9bb8mr5902622ejw.92.1655240486992; Tue, 14 Jun 2022 14:01:26 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id 24-20020a170906319800b00712134a676asm5539464ejy.93.2022.06.14.14.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 14:01:26 -0700 (PDT) Message-ID: <58039699-bc91-985a-cdfb-e0b156faf537@gmail.com> Date: Wed, 15 Jun 2022 00:01:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) Content-Language: en-US To: "Peng Fan (OSS)" , Simon Glass Cc: "u-boot@lists.denx.de" , Peng Fan , "tharvey@gateworks.com" , "sbabic@denx.de" , "festevam@gmail.com" , "trini@konsulko.com" References: <20220603071715.15212-1-peng.fan@oss.nxp.com> <20220603071715.15212-8-peng.fan@oss.nxp.com> From: Alper Nebi Yasak In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 13/06/2022 05:31, Peng Fan (OSS) wrote: >> 在 2022/6/11 0:47, Alper Nebi Yasak 写道: >>> Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables >>> you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares >>> certain symbols ('u_boot_any'). The name is a bit misleading, as if it >>> enables support for using symbols, and that confused me. >> I am not sure, but I think CONFIG_SPL/TPL_BINMAN_SYMBOLS are only for >> certain symbols saying u_boot_any. > > I mean I not think BINMAN_SYMBOLS are only for certtain symbols. They are right now, your patch changes that. I wasn't sure about changing it at first, but it makes more sense to me now. I'll update my series and split things out: - BINMAN: to run binman after build - BINMAN_SYMBOLS: to enable binman symbols, binman_sym.h - BINMAN_UBOOT_SYMBOLS: new config to declare u_boot_any symbols