From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 18 Oct 2016 07:17:25 +0200 Subject: [U-Boot] [PATCH] common: env: add kconfig entry for env storage In-Reply-To: <20161017225514.GW18591@bill-the-cat> References: <1475917562-3514-1-git-send-email-peng.fan@nxp.com> <20161017225514.GW18591@bill-the-cat> Message-ID: <5805B065.70209@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Am 18.10.2016 um 00:55 schrieb Tom Rini: > On Mon, Oct 17, 2016 at 04:17:06PM -0600, Simon Glass wrote: >> Hi Peng, >> >> On 8 October 2016 at 03:06, Peng Fan wrote: >>> Add Kconfig entry for ENV storage >>> >>> Signed-off-by: Peng Fan >>> Cc: Simon Glass >>> Cc: Heiko Schocher >>> Cc: Tom Rini >>> Cc: Masahiro Yamada >>> Cc: Stefan Roese >>> Cc: Siva Durga Prasad Paladugu >>> Cc: Francois Retief >>> --- >>> common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 73 insertions(+) >>> >>> diff --git a/common/Kconfig b/common/Kconfig >>> index c69c141..a630924 100644 >>> --- a/common/Kconfig >>> +++ b/common/Kconfig >>> @@ -158,6 +158,79 @@ config SPI_BOOT >>> >>> endmenu >>> >>> +menu "ENV storage media" >>> + >>> +config ENV_IS_IN_DATAFLASH >>> + bool "env stored in dataflash" >>> + help >>> + env stored in dataflash >> >> Can you add a little more help detail on this? Also I suspect we >> should have CONFIG_ENV as well, to enable the actual environment >> (independent of where it is stored). > > Yes, please add a bit more to the text. > >> Also, can you migrate the existing configs with moveconfig? That would >> be a big step forward and may inspire me to move it to linker lists. > > Actually, I bet this is going to be messy enough that I'm fine running > the moveconfig myself right before I merge it in. Feel free to give me the patch for running the tbot test [1], that the patch does not change binaries ... bye, Heiko [1] https://github.com/hsdenx/tbot/blob/master/src/tc/uboot/tc_uboot_check_kconfig.py -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany