public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] arm: samsung: Convert s5p_goni and smdkc100 to DM_I2C
Date: Mon, 5 Dec 2016 13:21:42 +0100	[thread overview]
Message-ID: <58455BD6.6060506@denx.de> (raw)
In-Reply-To: <1479908085-18336-3-git-send-email-sjg@chromium.org>

Hello Simon,

Am 23.11.2016 um 14:34 schrieb Simon Glass:
> These are the last two samsung boards that don't use DM_I2C. Move them
> over, leaving #ifdefs to allow the maintainer to complete this work.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   arch/arm/Kconfig           |  1 +
>   board/samsung/goni/goni.c  |  7 ++++++-
>   include/configs/s5p_goni.h | 19 -------------------
>   3 files changed, 7 insertions(+), 20 deletions(-)

Thanks!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 2427285..a87f692 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -412,6 +412,7 @@ config ARCH_S5PC1XX
>   	select DM
>   	select DM_SERIAL
>   	select DM_GPIO
> +	select DM_I2C
>
>   config ARCH_HIGHBANK
>   	bool "Calxeda Highbank"
> diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c
> index e8329bb..b066832 100644
> --- a/board/samsung/goni/goni.c
> +++ b/board/samsung/goni/goni.c
> @@ -45,11 +45,15 @@ void i2c_init_board(void)
>
>   int power_init_board(void)
>   {
> +#ifndef CONFIG_DM_I2C /* TODO(maintainer): Convert to driver model */
>   	/*
>   	 * For PMIC the I2C bus is named as I2C5, but it is connected
>   	 * to logical I2C adapter 0
>   	 */
>   	return pmic_init(I2C_0);
> +#else
> +	return 0;
> +#endif
>   }
>
>   int dram_init(void)
> @@ -142,6 +146,7 @@ int board_mmc_init(bd_t *bis)
>   #ifdef CONFIG_USB_GADGET
>   static int s5pc1xx_phy_control(int on)
>   {
> +#ifndef CONFIG_DM_I2C /* TODO(maintainer): Convert to driver model */
>   	int ret;
>   	static int status;
>   	struct pmic *p = pmic_get("MAX8998_PMIC");
> @@ -173,7 +178,7 @@ static int s5pc1xx_phy_control(int on)
>   		status = 0;
>   	}
>   	udelay(10000);
> -
> +#endif
>   	return 0;
>   }
>
> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> index 124cca3..6a5425a 100644
> --- a/include/configs/s5p_goni.h
> +++ b/include/configs/s5p_goni.h
> @@ -229,25 +229,6 @@
>
>   #define CONFIG_SYS_INIT_SP_ADDR	(CONFIG_SYS_LOAD_ADDR - 0x1000000)
>
> -#define CONFIG_POWER
> -#define CONFIG_POWER_I2C
> -#define CONFIG_POWER_MAX8998
> -
> -#include <asm/arch/gpio.h>
> -/*
> - * I2C Settings
> - */
> -#define CONFIG_SOFT_I2C_GPIO_SCL S5PC110_GPIO_J43
> -#define CONFIG_SOFT_I2C_GPIO_SDA S5PC110_GPIO_J40
> -
> -#define CONFIG_SYS_I2C
> -#define CONFIG_SYS_I2C_SOFT		/* I2C bit-banged */
> -#define CONFIG_SYS_I2C_SOFT_SPEED	50000
> -#define CONFIG_SYS_I2C_SOFT_SLAVE	0x7F
> -#define CONFIG_I2C_MULTI_BUS
> -#define CONFIG_SYS_I2C_INIT_BOARD
> -
> -#define CONFIG_SYS_MAX_I2C_BUS	7
>   #define CONFIG_USB_GADGET_DWC2_OTG_PHY
>   #define CONFIG_USB_FUNCTION_MASS_STORAGE
>
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2016-12-05 12:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161123133513epcas2p188fdff5c8a25f7fa796e11fb53becf20@epcas2p1.samsung.com>
2016-11-23 13:34 ` [U-Boot] [PATCH 0/6] dm: i2c: Set a timeline for conversion of i2c drivers Simon Glass
2016-11-23 13:34   ` [U-Boot] [PATCH 1/6] arm: exynos: i2c: Convert exynos boards to use DM_I2C Simon Glass
2016-12-05 12:21     ` Heiko Schocher
2016-11-23 13:34   ` [U-Boot] [PATCH 2/6] arm: samsung: Convert s5p_goni and smdkc100 to DM_I2C Simon Glass
2016-12-05 12:21     ` Heiko Schocher [this message]
2016-11-23 13:34   ` [U-Boot] [PATCH 3/6] samsung: i2c: Drop old code from I2C driver Simon Glass
2016-12-05 12:22     ` Heiko Schocher
2016-11-23 13:34   ` [U-Boot] [PATCH 4/6] samsung: i2c: Split the high-speed I2C code into a new driver Simon Glass
2016-12-05 12:23     ` Heiko Schocher
2016-11-23 13:34   ` [U-Boot] [PATCH 5/6] dm: i2c: Add a note to I2C drivers which need conversion Simon Glass
2016-12-05 12:25     ` Heiko Schocher
2016-11-23 13:34   ` [U-Boot] [PATCH 6/6] dm: Add timeline and guide for porting I2C drivers Simon Glass
2016-11-23 14:52     ` Michal Simek
2016-11-23 16:13       ` Simon Glass
2016-12-05 12:25     ` Heiko Schocher
2016-12-05 22:47   ` [U-Boot] [PATCH 0/6] dm: i2c: Set a timeline for conversion of i2c drivers Jaehoon Chung
2016-12-07  0:53     ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58455BD6.6060506@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox