[U-Boot] [PATCH v3 02/13] net: fec_mxc: Convert into driver model

Joe Hershberger
2016-12-09T18:22:25Z

Hi Jagan,

On Mon, Dec 5, 2016 at 5:00 PM, Jagan Teki <jagan@openedev.com> wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> This patch add driver model support for fec_mxc driver.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v3:
> - Removed the stub functions[1] and revert back to previous changes where #ifdef on
> each function call. We can't use the stub functions to minimize the #ifdef's as the
> driver is organize the code in such a way that it can't modularized the code. So better
> to use #ifdef to not to break the non-dm.
>
> [1] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=fa2ce02b73fa59fe91d2d0ad61bf837392e03ab9

So the plan is to drop that from u-boot-imx and use this instead? If so,

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

> drivers/net/fec_mxc.c | 268 +++++++++++++++++++++++++++++++++++++++++++++-----
> drivers/net/fec_mxc.h | 4 +
> 2 files changed, 246 insertions(+), 26 deletions(-)