[U-Boot] [PATCH] serial, ns16550: bugfix: ns16550 fifo not enabled

Heiko Schocher
2017-01-12T04:35:49Z

Hello Adam,

Am 11.01.2017 um 15:44 schrieb Adam Ford:
> On Tue, Jan 10, 2017 at 1:08 AM, Heiko Schocher <hs@denx.de> wrote:
>> commit: 65f83802b7a5b "serial: 16550: Add getfcr accessor"
>> breaks u-boot commandline working with long commands
>> sending to the board.
>>
>> Since the above patch, you have to setup the fcr register.
>>
>> For board/archs which enable OF_PLATDATA, the new field
>> fcr in struct ns16550_platdata is not filled with a
>> default value ...
>>
>> This leads in not setting up the uarts fifo, which ends
>> in problems, when you send long commands to u-boots
>> commandline.
>>
>> Detected this issue with automated tbot tests on am335x
>> based shc board.
>>
>> The error does not popup, if you type commands. You need
>> to copy&paste a long command to u-boots commandshell
>> (or send a long command with tbot)
>>
>> Possible boards/plattforms with problems:
>> ./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
>> ./arch/arm/mach-tegra/board.c
>> ./board/isee/igep00x0/igep00x0.c
>> ./board/overo/overo.c
>> ./board/quipos/cairo/cairo.c
>> ./board/logicpd/omap3som/omap3logic.c
>> ./board/logicpd/zoom1/zoom1.c
>> ./board/timll/devkit8000/devkit8000.c
>> ./board/lg/sniper/sniper.c
>> ./board/ti/beagle/beagle.c
>> ./drivers/serial/serial_rockchip.c
>>
>> This patch fixes only:
>> ./arch/arm/mach-omap2/am33xx/board.c
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>
> The omap3logic is also affected. It also appears as if you hold a
> character down while booting, it may hang the system. I applied a
> similar patch to omap3logic.c and it went away.

Thanks for testing!

> Thanks for catching that!

Thanks goes to tbot [1] and weekly automated u-boot tests with
tbot integrated into buildbot [2]

(I also automated "git bisect" to find the, which commit breaks
a board ... if interested in a demo video, see[5])

bye,
Heiko
[1] https://github.com/hsdenx/tbot
[2] http://xeidos.ddns.net/buildbot/tgrid
[3] tbot result webpage
http://xeidos.ddns.net/tests/test_db_auslesen.php
[4] tbot dokumentation
http://www.tbot.tools/main.html
[5] tbot demo on youtube
https://youtu.be/zfjpj3DLsx4
Its uncutted, so very long, but in the video comment I added
timemarkers, where the interesting parts are ...
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany