[U-Boot] [RFC PATCH 1/3] arm64: rk3399: add SPL support

Simon Glass
2017-01-13T02:11:13Z

Hi Kever,

On 29 December 2016 at 03:25, Kever Yang <kever.yang@rock-chips.com> wrote:
> Add spl support for rk3399.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> arch/arm/Kconfig | 1 +
> arch/arm/dts/rk3399.dtsi | 24 ++++
> arch/arm/include/asm/arch-rockchip/grf_rk3399.h | 118 ++++++++++++++++++
> arch/arm/mach-rockchip/Kconfig | 2 +
> arch/arm/mach-rockchip/Makefile | 1 +
> arch/arm/mach-rockchip/rk3399-board-spl.c | 157 ++++++++++++++++++++++++
> configs/evb-rk3399_defconfig | 17 +++
> drivers/clk/rockchip/clk_rk3399.c | 42 ++++++-
> drivers/pinctrl/rockchip/pinctrl_rk3399.c | 106 ----------------
> include/configs/rk3399_common.h | 11 ++
> include/dt-bindings/clock/rk3399-cru.h | 16 ++-
> 11 files changed, 382 insertions(+), 113 deletions(-)
> create mode 100644 arch/arm/mach-rockchip/rk3399-board-spl.c

The code looks fine. But can you please split this into 3 patches?

- move grf register definitions to grf_rk3399.h
- add clock driver
- add SPL support

Also check your header #ifdef guards - they should not have SOC in them.

Regards,
Simon