From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3AABC4332F for ; Fri, 2 Dec 2022 19:06:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E4A3184F46; Fri, 2 Dec 2022 20:06:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="ioS4yz1/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2C286850EE; Fri, 2 Dec 2022 20:06:35 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CA67684F46 for ; Fri, 2 Dec 2022 20:06:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=detlev.casanova@collabora.com Received: from falcon9.localnet (bras-base-mtrlpq02hsy-grc-05-174-93-253-174.dsl.bell.ca [174.93.253.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 87B206602BC1; Fri, 2 Dec 2022 19:06:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1670007991; bh=VsiCZoAt0gY0kEDDFT5DEgOJFCFvRw5elOrXx3zNSW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ioS4yz1/4c6If4LOOMVi7C89+WJnlG5K0aN8be0tCJgki6LodtGrUORPMrArdoJpL 72w6/3ey9eyBfACxkamVB6tEgTi63stUOrqpBbV9+Qv2xZPtSmBHVVRiDBVXsxstjg njHJ/DF2J2s2JwGTMkcE+cyLseWvTiB5Y0fU5+k3xPXBi8B5m6YxDqn+hOH56aDack nNEdcrcON/9k/btZquDFzZLbKLZF8D9ZGsZPv64sajPyyPHfIpmIhaDyUsnJZURrji t1nVF34E1DMaS/ccX0YztUKJUTHh7qmpAmNFrWuqybWkWarpfMQwshOrv1Z98GC17f nnOw+fGRr0kWw== From: Detlev Casanova To: Tom Rini Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Date: Fri, 02 Dec 2022 14:06:26 -0500 Message-ID: <5883089.lOV4Wx5bFT@falcon9> In-Reply-To: <20221111153556.GF7282@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <13125638.O9o76ZdvQC@falcon9> <20221111153556.GF7282@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Friday, November 11, 2022 10:35:56 A.M. EST Tom Rini wrote: > On Fri, Nov 11, 2022 at 10:28:43AM -0500, Detlev Casanova wrote: > > On Thursday, October 27, 2022 2:30:51 P.M. EST Tom Rini wrote: > > > On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote: > > > > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree > > > > was > > > > synchronized from linux and the aliases were dropped. > > > > > > > > They need to be kept so that the mmc cards are in the right order. > > > > Without the aliases, u-boot reports: > > > > MMC: FSL_SDHC: 2, FSL_SDHC: 3 > > > > > > > > With the aliases, u-boot reports: > > > > MMC: FSL_SDHC: 0, FSL_SDHC: 1 > > > > > > > > Signed-off-by: Detlev Casanova > > > > --- > > > > > > > > arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > b/arch/arm/dts/imx6qdl-sabrelite.dtsi index 22f8e2783c..6564e3b82c > > > > 100644 > > > > --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > @@ -10,6 +10,13 @@ > > > > > > > > #include > > > > > > > > / { > > > > > > > > + aliases { > > > > + mmc0 = &usdhc3; > > > > + mmc1 = &usdhc4; > > > > + pwm_lcd = &pwm1; > > > > + pwm_lvds = &pwm4; > > > > + }; > > > > + > > > > > > > > chosen { > > > > > > > > stdout-path = &uart2; > > > > > > > > }; > > > > > > This really belongs in the upstream dts file so they aren't lost again > > > and again. > > > > Forwaded to upstream kernel: > > https://lore.kernel.org/lkml/20221028141811.101122-1-detlev.casanova@coll > > abora.com/[1] > > > > Would it make sense to still add this one in u-boot before the devices > > trees are copied again ? > Yes, it would make sense to pick it up now to fix the regression here. > Thanks for pushing it upstream! Upstream linux won't apply it as they want to keep the already established order in linux (the SD card has to stay at mmc2). See https://lore.kernel.org/all/a13c2e92-cfa6-04fd-c32a-c4d444894660@pengutronix.de/[1] I guess we will have to adapt u-boot environment when these dts are synced again. Detlev. -------- [1] https://lore.kernel.org/all/a13c2e92-cfa6-04fd-c32a-c4d444894660@pengutronix.de/