Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

Michael Walle
2022-12-08T13:36:13Z

Hi,

>> I'm not really happy with this approach. It's not that upstream doesn't
>> have aliases now, it's that it has different aliases, right? That's why
>> they won't accept these?
>
> imx6q.dtsi does have the default mmc aliases:
>
> mmc0 = &usdhc1;
> mmc1 = &usdhc2;
> mmc2 = &usdhc3;
> mmc3 = &usdhc4;
>
> Upstream does not want to change mmc alias because users may rely on
> this mmc aliases.

This thread seems to be another reason *not* to put any aliases
into a common dtsi file. They are board specific and should
really go into the board dts.

-michael