* [U-Boot] [PATCH] tools: Correct python building host tools
@ 2017-01-23 16:44 Tom Rini
2017-01-23 17:12 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Rini @ 2017-01-23 16:44 UTC (permalink / raw)
To: u-boot
When we have python building tools for the host it will not check HOSTXX
variables but only XX variables, for example LDFLAGS and not
HOSTLDFLAGS.
Cc: Simon Glass <sjg@chromium.org>
Reported-by: Heiko Schocher <hs@denx.de>
Fixes: 1905c8fc711a ("build: Always build the libfdt python module")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
tools/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index a609d058595b..cefcedf683ca 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
libfdt:
tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
- python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
+ LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
+ "$(_hostc_flags)" $^
mv _libfdt.so $@
tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] tools: Correct python building host tools
2017-01-23 16:44 [U-Boot] [PATCH] tools: Correct python building host tools Tom Rini
@ 2017-01-23 17:12 ` Simon Glass
2017-01-24 6:06 ` Heiko Schocher
2017-01-25 2:15 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2017-01-23 17:12 UTC (permalink / raw)
To: u-boot
On 23 January 2017 at 09:44, Tom Rini <trini@konsulko.com> wrote:
> When we have python building tools for the host it will not check HOSTXX
> variables but only XX variables, for example LDFLAGS and not
> HOSTLDFLAGS.
>
> Cc: Simon Glass <sjg@chromium.org>
> Reported-by: Heiko Schocher <hs@denx.de>
> Fixes: 1905c8fc711a ("build: Always build the libfdt python module")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> tools/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index a609d058595b..cefcedf683ca 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
> libfdt:
>
> tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
> - python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
> + LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
> + "$(_hostc_flags)" $^
> mv _libfdt.so $@
>
> tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig
> --
> 1.9.1
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested on 5 PowerPC builds:
Tested-by: Simon Glass <sjg@chromium.org>
Thanks Tom!
- Simon
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] tools: Correct python building host tools
2017-01-23 16:44 [U-Boot] [PATCH] tools: Correct python building host tools Tom Rini
2017-01-23 17:12 ` Simon Glass
@ 2017-01-24 6:06 ` Heiko Schocher
2017-01-25 2:15 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2017-01-24 6:06 UTC (permalink / raw)
To: u-boot
Hello Tom,
Am 23.01.2017 um 17:44 schrieb Tom Rini:
> When we have python building tools for the host it will not check HOSTXX
> variables but only XX variables, for example LDFLAGS and not
> HOSTLDFLAGS.
>
> Cc: Simon Glass <sjg@chromium.org>
> Reported-by: Heiko Schocher <hs@denx.de>
> Fixes: 1905c8fc711a ("build: Always build the libfdt python module")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> tools/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks! This fixes the build for the tqm5200 board.
Tested-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/tools/Makefile b/tools/Makefile
> index a609d058595b..cefcedf683ca 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
> libfdt:
>
> tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
> - python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
> + LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
> + "$(_hostc_flags)" $^
> mv _libfdt.so $@
>
> tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] tools: Correct python building host tools
2017-01-23 16:44 [U-Boot] [PATCH] tools: Correct python building host tools Tom Rini
2017-01-23 17:12 ` Simon Glass
2017-01-24 6:06 ` Heiko Schocher
@ 2017-01-25 2:15 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2017-01-25 2:15 UTC (permalink / raw)
To: u-boot
On Mon, Jan 23, 2017 at 11:44:33AM -0500, Tom Rini wrote:
> When we have python building tools for the host it will not check HOSTXX
> variables but only XX variables, for example LDFLAGS and not
> HOSTLDFLAGS.
>
> Cc: Simon Glass <sjg@chromium.org>
> Reported-by: Heiko Schocher <hs@denx.de>
> Fixes: 1905c8fc711a ("build: Always build the libfdt python module")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org>
> Tested-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170124/ddf1c485/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-25 2:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-23 16:44 [U-Boot] [PATCH] tools: Correct python building host tools Tom Rini
2017-01-23 17:12 ` Simon Glass
2017-01-24 6:06 ` Heiko Schocher
2017-01-25 2:15 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox