From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: 16550: properly initialize fcr field of ns16550_platdata
Date: Thu, 2 Feb 2017 06:13:48 +0100 [thread overview]
Message-ID: <5892C00C.5090508@denx.de> (raw)
In-Reply-To: <20170201185217.GA60908@bluezbox.com>
Hello Oleksandr,
Am 01.02.2017 um 19:52 schrieb Oleksandr Tymoshenko:
> Tom Rini (trini at konsulko.com) wrote:
>> On Tue, Jan 31, 2017 at 05:15:20PM -0800, Oleksandr Tymoshenko wrote:
>>
>>> Default fcr value is initialized in ns16550_serial_ofdata_to_platdata
>>> but this function is only called if OF_CONTROL option is enabled while
>>> the field is used whenever DM_SERIAL is set. So for configs that
>>> do not have OF_CONTROL default fcr value is set to zero which leads
>>> to loosing characters when serial port input is faster than reading
>>> routine i.e. when copy-pasting long line to U-Boot prompt.
>>>
>>> As a fix initialize fcr field in probe method
>>>
>>> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
>>> Cc: Marek Vasut <marex@denx.de>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>
>> Are you still seeing this with v2017.03-rc1? Thanks!
>
> No, this bug is not reproducible on v2017.03-rc1, I believe 17fa032671
> fixed it. Not sure how I missed that patch I am pretty sure I tested my
> BBB with master branch.
Yes commit 17fa032671 fixed this issue. How do you test? You must
type very fast, or copy&paste a long command ...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2017-02-02 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 1:15 [U-Boot] [PATCH] serial: 16550: properly initialize fcr field of ns16550_platdata Oleksandr Tymoshenko
2017-02-01 8:46 ` Marek Vasut
2017-02-01 13:12 ` Tom Rini
2017-02-01 18:52 ` Oleksandr Tymoshenko
2017-02-02 5:13 ` Heiko Schocher [this message]
2017-02-02 5:36 ` Oleksandr Tymoshenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5892C00C.5090508@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox