From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] arm64: rk3399: add SPL support
Date: Sun, 05 Feb 2017 11:01:05 +0800 [thread overview]
Message-ID: <58969571.9020803@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ2dc-XNwO5uH1gVirCisZRKWMUk=dGdZC2OKcomdJYFvA@mail.gmail.com>
Hi Simon,
On 01/26/2017 10:23 PM, Simon Glass wrote:
> Hi Kever,
>
> On 18 January 2017 at 05:16, Kever Yang <kever.yang@rock-chips.com> wrote:
>> Add spl support for rk3399, default with of-platdata enabled.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> arch/arm/Kconfig | 1 +
>> arch/arm/dts/rk3399-evb.dts | 2 +
>> arch/arm/dts/rk3399.dtsi | 44 +++++++
>> arch/arm/include/asm/arch-rockchip/clock.h | 3 +
>> arch/arm/mach-rockchip/Kconfig | 2 +
>> arch/arm/mach-rockchip/Makefile | 1 +
>> arch/arm/mach-rockchip/rk3399-board-spl.c | 158 ++++++++++++++++++++++++++
>> arch/arm/mach-rockchip/rk3399/syscon_rk3399.c | 40 +++++++
>> configs/evb-rk3399_defconfig | 18 +++
>> include/configs/rk3399_common.h | 11 ++
>> 10 files changed, 280 insertions(+)
>> create mode 100644 arch/arm/mach-rockchip/rk3399-board-spl.c
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> But there is too much in this patch. Please split out the patches. My
> suggestion:
>
> - syscon additions
> - dts/dtsi additions
> - arch/arm/Kconfig and include/configs changes
> - board-spl.c stuff
> - defconfig changes to enable everything
>
> So it should be possible to enable/disable SPL just in the final patch.
Cc Tom here.
I have some confuse for patch split in U-Boot, last time I see a patch
set to init support
for other SoC, patches split very detail and almost one patch for one
module(like your comment
in this patch), then Tom's comment says there is no need for that
detail, only one patch for SoC
and one patch for board is OK.
My understand(for U-Boot) is:
- driver patch is very clear and should be split out,
- other parts like dts/defconfig and soc/board for one new SoC support,
could be gather in one patch or two if there goes to the same
maintainer and branch.
The grf definition and clock driver has split out as your comment in my
'RFC' version,
I can split this patch into 5 patches if you still required.
Thanks,
- Kever
>
> Regards,
> Simon
>
>
>
next prev parent reply other threads:[~2017-02-05 3:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 12:16 [U-Boot] [PATCH 0/6] rk3399: enable SPL driver Kever Yang
2017-01-18 12:16 ` [U-Boot] [PATCH 1/6] arm64: rk3399: add ddr controller driver Kever Yang
2017-01-26 14:23 ` Simon Glass
2017-02-05 2:45 ` Kever Yang
2017-02-08 5:10 ` Simon Glass
2017-02-13 7:52 ` Kever Yang
2017-01-18 12:16 ` [U-Boot] [PATCH 2/6] arm64: rk3399: move grf register definitions to grf_rk3399.h Kever Yang
2017-01-25 4:09 ` Simon Glass
2017-01-18 12:16 ` [U-Boot] [PATCH 3/6] clk: rk3399: update driver for spl Kever Yang
2017-01-26 14:23 ` Simon Glass
2017-01-18 12:16 ` [U-Boot] [PATCH 4/6] sdhci: rk3399: update driver to support of-platdata Kever Yang
2017-01-26 14:23 ` Simon Glass
2017-01-18 12:16 ` [U-Boot] [PATCH 5/6] pinctrl: rk3399: add the of-platdata support Kever Yang
2017-01-26 14:23 ` Simon Glass
2017-01-18 12:16 ` [U-Boot] [PATCH 6/6] arm64: rk3399: add SPL support Kever Yang
2017-01-26 14:23 ` Simon Glass
2017-02-05 3:01 ` Kever Yang [this message]
2017-02-08 5:10 ` Simon Glass
2017-01-24 13:51 ` [U-Boot] [PATCH 0/6] rk3399: enable SPL driver Simon Glass
2017-02-05 1:41 ` Kever Yang
2017-02-08 5:10 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58969571.9020803@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox