From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl_i2c.c: Fix warning on gcc-6.x
Date: Fri, 10 Feb 2017 08:02:31 +0100 [thread overview]
Message-ID: <589D6587.7070603@denx.de> (raw)
In-Reply-To: <1486672816-10748-1-git-send-email-trini@konsulko.com>
Hello Tom,
Am 09.02.2017 um 21:40 schrieb Tom Rini:
> With gcc-6.x we see:
> drivers/i2c/fsl_i2c.c:86:3: warning: ?fsl_i2c_speed_map? defined but not
> used [-Wunused-const-variable=]
>
> The easy way to fix this is that since we only use fsl_i2c_speed_map at
> all on __M68K__ move the existing guards around slightly.
>
> Reported-by: Thomas Schaefer <Thomas.Schaefer@kontron.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> drivers/i2c/fsl_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Acked-by: Heiko Schocher <hs@denx.de>
Do you want to pick up this patch directly, or should I send an i2c pull
request?
bye,
Heiko
>
> diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
> index e9fbf828f34b..a1406baa87b2 100644
> --- a/drivers/i2c/fsl_i2c.c
> +++ b/drivers/i2c/fsl_i2c.c
> @@ -53,6 +53,7 @@ static const struct fsl_i2c_base *i2c_base[4] = {
>
> /* I2C speed map for a DFSR value of 1 */
>
> +#ifdef __M68K__
> /*
> * Map I2C frequency dividers to FDR and DFSR values
> *
> @@ -84,7 +85,6 @@ static const struct {
> unsigned short divider;
> u8 fdr;
> } fsl_i2c_speed_map[] = {
> -#ifdef __M68K__
> {20, 32}, {22, 33}, {24, 34}, {26, 35},
> {28, 0}, {28, 36}, {30, 1}, {32, 37},
> {34, 2}, {36, 38}, {40, 3}, {40, 39},
> @@ -102,8 +102,8 @@ static const struct {
> {1536, 61}, {1792, 62}, {1920, 27}, {2048, 63},
> {2304, 28}, {2560, 29}, {3072, 30}, {3840, 31},
> {-1, 31}
> -#endif
> };
> +#endif
>
> /**
> * Set the I2C bus speed for a given I2C device
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2017-02-10 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 20:40 [U-Boot] [PATCH] fsl_i2c.c: Fix warning on gcc-6.x Tom Rini
2017-02-10 7:02 ` Heiko Schocher [this message]
2017-02-11 3:21 ` Tom Rini
2017-02-17 22:56 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589D6587.7070603@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox