From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] rockchip breakage with "spl: Remove overwrite of relocated malloc limit"
Date: Tue, 07 Mar 2017 14:56:26 +0800 [thread overview]
Message-ID: <58BE599A.3040409@rock-chips.com> (raw)
In-Reply-To: <5416401.pcIAmeSpSx@diego>
Hi Heiko,
That patch break all the Rockchip SoCs SPL which using spl_init().
Eddie send one patch for rk3288 by add a spl_early_init(), which is
under review, I also look forward for better solution.
Thanks,
- Kever
On 03/07/2017 08:42 AM, Heiko Stübner wrote:
> Hi,
>
> I just realized patch b3d2861eb20a ("spl: Remove overwrite of relocated malloc
> limit") introduces breakage in my rk3188 uboot code (and should most likely
> also affect the very similar other rockchip spl boards).
>
> The boards call spl_init in their board_init_f functions because they need the
> spl infrastructure to find and bringup the devicetree stuff and things like
> pinctrl and ram.
>
> With the recent change mentioned above, spl_init fails with
> spl_init() failed: -12
> because
> dm_init_and_scan() returned error -12
> because
> dm_init() failed: -12
> ...
> because
> Missing uclass for driver root_driver
> because
> uclass_add calls calloc, which fails with the -ENOMEM (-12)
>
> I still lack uboot experience to see the correct way forward. Reverting that
> patch of course makes my board start uboot again [and most likely the other
> Rockchip SPLs as well], but there is possibly some better solution
> [Or there is simply something very wrong with my rk3188 stuff :-) ].
>
>
> Heiko
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
next prev parent reply other threads:[~2017-03-07 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 0:42 [U-Boot] rockchip breakage with "spl: Remove overwrite of relocated malloc limit" Heiko Stübner
2017-03-07 6:56 ` Kever Yang [this message]
2017-03-07 17:01 ` Simon Glass
2017-03-07 18:39 ` Heiko Stübner
2017-03-07 18:45 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BE599A.3040409@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox