public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] rockchip: config: rk3399: update defconfigs and rk3399_common
Date: Fri, 24 Mar 2017 10:13:26 +0800	[thread overview]
Message-ID: <58D480C6.3090603@rock-chips.com> (raw)
In-Reply-To: <1490307853-11618-3-git-send-email-philipp.tomsich@theobroma-systems.com>

Hi Philipp,

On 03/24/2017 06:24 AM, Philipp Tomsich wrote:
> With everything set up to define CONFIG_BAUDRATE via defconfig and
> with to have the SPL debug UART either on UART0 or UART2, the configs
> for the RK3399 EVB and for the RK3399-Q7 can be updated.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
> Changes in v2: None
>
>   configs/evb-rk3399_defconfig    | 2 ++
>   configs/puma_defconfig          | 4 +++-
>   include/configs/rk3399_common.h | 1 -
>   3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
> index 22405ce..7a82869 100644
> --- a/configs/evb-rk3399_defconfig
> +++ b/configs/evb-rk3399_defconfig
> @@ -43,7 +43,9 @@ CONFIG_DM_REGULATOR_FIXED=y
>   CONFIG_PWM_ROCKCHIP=y
>   CONFIG_RAM=y
>   CONFIG_SPL_RAM=y
> +CONFIG_BAUDRATE=1500000
>   CONFIG_DEBUG_UART=y
> +CONFIG_DEBUG_UART_BOARD_INIT=y
>   CONFIG_DEBUG_UART_BASE=0xFF1A0000
>   CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_DEBUG_UART_SHIFT=2
> diff --git a/configs/puma_defconfig b/configs/puma_defconfig
> index 515185e..8e29d96 100644
> --- a/configs/puma_defconfig
> +++ b/configs/puma_defconfig
> @@ -43,8 +43,10 @@ CONFIG_DM_REGULATOR_FIXED=y
>   CONFIG_PWM_ROCKCHIP=y
>   CONFIG_RAM=y
>   CONFIG_SPL_RAM=y
> +CONFIG_BAUDRATE=115200
>   CONFIG_DEBUG_UART=y
> -CONFIG_DEBUG_UART_BASE=0xFF1A0000
> +CONFIG_DEBUG_UART_BOARD_INIT=y
> +CONFIG_DEBUG_UART_BASE=0xFF180000
>   CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_SYS_NS16550=y
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index bc91eb6..c1ea616 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -12,7 +12,6 @@
>   #define CONFIG_NR_DRAM_BANKS		1
>   #define CONFIG_ENV_SIZE			0x2000
>   #define CONFIG_SYS_MAXARGS		16
> -#define CONFIG_BAUDRATE			1500000
>   #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
>   #define CONFIG_SYS_CBSIZE		1024
>   #define CONFIG_SKIP_LOWLEVEL_INIT

Looks good to me.

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

  reply	other threads:[~2017-03-24  2:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 22:24 [U-Boot] [PATCH v2 0/2] rockchip: rk3399: spl: Make baudrate and UART configurable Philipp Tomsich
2017-03-23 22:24 ` [U-Boot] [PATCH v2 1/2] rockchip: rk3399: spl: add UART0 support for SPL Philipp Tomsich
2017-03-24  2:12   ` Kever Yang
2017-03-26  2:38     ` Simon Glass
2017-03-26 16:30       ` Dr. Philipp Tomsich
2017-04-01  4:22         ` Simon Glass
2017-03-23 22:24 ` [U-Boot] [PATCH v2 2/2] rockchip: config: rk3399: update defconfigs and rk3399_common Philipp Tomsich
2017-03-24  2:13   ` Kever Yang [this message]
2017-03-26  1:17   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D480C6.3090603@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox