From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Fri, 24 Mar 2017 10:13:26 +0800 Subject: [U-Boot] [PATCH v2 2/2] rockchip: config: rk3399: update defconfigs and rk3399_common In-Reply-To: <1490307853-11618-3-git-send-email-philipp.tomsich@theobroma-systems.com> References: <1490307853-11618-1-git-send-email-philipp.tomsich@theobroma-systems.com> <1490307853-11618-3-git-send-email-philipp.tomsich@theobroma-systems.com> Message-ID: <58D480C6.3090603@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Philipp, On 03/24/2017 06:24 AM, Philipp Tomsich wrote: > With everything set up to define CONFIG_BAUDRATE via defconfig and > with to have the SPL debug UART either on UART0 or UART2, the configs > for the RK3399 EVB and for the RK3399-Q7 can be updated. > > Signed-off-by: Philipp Tomsich > > --- > > Changes in v2: None > > configs/evb-rk3399_defconfig | 2 ++ > configs/puma_defconfig | 4 +++- > include/configs/rk3399_common.h | 1 - > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig > index 22405ce..7a82869 100644 > --- a/configs/evb-rk3399_defconfig > +++ b/configs/evb-rk3399_defconfig > @@ -43,7 +43,9 @@ CONFIG_DM_REGULATOR_FIXED=y > CONFIG_PWM_ROCKCHIP=y > CONFIG_RAM=y > CONFIG_SPL_RAM=y > +CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART=y > +CONFIG_DEBUG_UART_BOARD_INIT=y > CONFIG_DEBUG_UART_BASE=0xFF1A0000 > CONFIG_DEBUG_UART_CLOCK=24000000 > CONFIG_DEBUG_UART_SHIFT=2 > diff --git a/configs/puma_defconfig b/configs/puma_defconfig > index 515185e..8e29d96 100644 > --- a/configs/puma_defconfig > +++ b/configs/puma_defconfig > @@ -43,8 +43,10 @@ CONFIG_DM_REGULATOR_FIXED=y > CONFIG_PWM_ROCKCHIP=y > CONFIG_RAM=y > CONFIG_SPL_RAM=y > +CONFIG_BAUDRATE=115200 > CONFIG_DEBUG_UART=y > -CONFIG_DEBUG_UART_BASE=0xFF1A0000 > +CONFIG_DEBUG_UART_BOARD_INIT=y > +CONFIG_DEBUG_UART_BASE=0xFF180000 > CONFIG_DEBUG_UART_CLOCK=24000000 > CONFIG_DEBUG_UART_SHIFT=2 > CONFIG_SYS_NS16550=y > diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h > index bc91eb6..c1ea616 100644 > --- a/include/configs/rk3399_common.h > +++ b/include/configs/rk3399_common.h > @@ -12,7 +12,6 @@ > #define CONFIG_NR_DRAM_BANKS 1 > #define CONFIG_ENV_SIZE 0x2000 > #define CONFIG_SYS_MAXARGS 16 > -#define CONFIG_BAUDRATE 1500000 > #define CONFIG_SYS_MALLOC_LEN (32 << 20) > #define CONFIG_SYS_CBSIZE 1024 > #define CONFIG_SKIP_LOWLEVEL_INIT Looks good to me. Reviewed-by: Kever Yang Thanks, - Kever