public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: spl: RK3399: add COUNTER_FREQUENCY define to rk3399_common.h
Date: Fri, 24 Mar 2017 11:39:23 +0800	[thread overview]
Message-ID: <58D494EB.3070009@rock-chips.com> (raw)
In-Reply-To: <1490308065-12420-1-git-send-email-philipp.tomsich@theobroma-systems.com>

Hi Philipp,

On 03/24/2017 06:27 AM, Philipp Tomsich wrote:
> The BootROM of the RK3399 SoC does not initialise the cntfrq_el0 (which
> holds the value 0 (zero) on entry into the SPL. This causes the timebase
> for U-Boot not to advance (and will cause a hang where a timeout would
> be expected... e.g. if something goes wrong during MMC/SD card startup).
>
> This change defines COUNTER_FREQUENCY, which is used by the AArch64 init
> code in arch/arm/cpu/armv8/start.S to set up cntfrq_el0 (if necessary).
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
>   include/configs/rk3399_common.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index aeee805..c44f8ad 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -19,6 +19,8 @@
>   #define CONFIG_SPL_DRIVERS_MISC_SUPPORT
>   #define CONFIG_SPL_SERIAL_SUPPORT
>   
> +#define COUNTER_FREQUENCY               24000000
> +
>   #define CONFIG_SYS_NS16550_MEM32
>   
>   #define CONFIG_SYS_TEXT_BASE		0x00200000

Reveiwed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

  reply	other threads:[~2017-03-24  3:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 22:27 [U-Boot] [PATCH] rockchip: spl: RK3399: add COUNTER_FREQUENCY define to rk3399_common.h Philipp Tomsich
2017-03-24  3:39 ` Kever Yang [this message]
2017-03-26  3:47   ` Simon Glass
2017-04-02  0:05     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D494EB.3070009@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox