[U-Boot] [bug report] Incorrect result from clk_get_by_name

[U-Boot] [bug report] Incorrect result from clk_get_by_name

[Ziyuan]

hi all,

I hit an issue about clk_get_by_name w/ fdt.
I wanna get a specified clock cell from dts via clk_get_by_name. eg:
clk_get_by_name(, "ciu-sample",..) from 'emmc: dwmmc at ff0f0000' on rk3288 
platform which it has four clock cell: "biu", "ciu", "ciu_drv", 
"ciu_sample".
I found that the clock list has only one element, it's "biu". I expected 
that there are four elements.

Actually, I can use clk_get_by_index instead, but I prefer clock name, 
it's more readable.

Ziyuan Xu
BR

[U-Boot] [bug report] Incorrect result from clk_get_by_name

[Simon Glass]

Hi,

On 9 April 2017 at 20:45, Ziyuan <xzy.xu@rock-chips.com> wrote:
> hi all,
>
> I hit an issue about clk_get_by_name w/ fdt.
> I wanna get a specified clock cell from dts via clk_get_by_name. eg:
> clk_get_by_name(, "ciu-sample",..) from 'emmc: dwmmc at ff0f0000' on rk3288
> platform which it has four clock cell: "biu", "ciu", "ciu_drv",
> "ciu_sample".
> I found that the clock list has only one element, it's "biu". I expected
> that there are four elements.
>
> Actually, I can use clk_get_by_index instead, but I prefer clock name, it's
> more readable.

Perhaps there is a bug in fdt_stringlist_search()? Can you try to debug it?

Also I see that test/dm/clk.c does not have a test for
clk_get_by_name(). If you have time, please add a test for that since
it is an important function.

Regards,
Simon