public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399
Date: Mon, 10 Apr 2017 05:55:25 +0200	[thread overview]
Message-ID: <58EB022D.1050606@denx.de> (raw)
In-Reply-To: <1491654135-10947-2-git-send-email-eric.gao@rock-chips.com>

Hello Eric,

Am 08.04.2017 um 14:22 schrieb Eric Gao:
> From: "eric.gao" <eric.gao@rock-chips.com>
>
> To enable mipi display, we need to enable pmic
> rk808 first for lcd3v3 power,which use i2c0 to
> communicate with soc. So enable i2c0.
>
> Signed-off-by: eric.gao <eric.gao@rock-chips.com>
>
> Signed-off-by: Eric Gao <eric.gao@rock-chips.com>

Why you have 2 "Signed-off-by" lines?

> ---
>
>   arch/arm/dts/rk3399.dtsi     | 16 ++++++++++++++++
>   configs/evb-rk3399_defconfig |  1 +
>   drivers/i2c/rk_i2c.c         |  1 +
>   3 files changed, 18 insertions(+)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2017-04-10  3:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08 12:22 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:22 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-10  3:55   ` Heiko Schocher [this message]
2017-04-10  6:19     ` Eric
  -- strict thread matches above, loose matches on Subject: below --
2017-04-10  2:41 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-10  2:41 ` [U-Boot] [PATCH 1/5] rockchip: i2c: Enable i2c for rk3399 Eric Gao
2017-04-10  2:17 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-10  2:17 ` [U-Boot] [PATCH 1/5] rockchip: i2c: Enable i2c for rk3399 Eric Gao
2017-04-11 13:55   ` Simon Glass
2017-04-14 10:15     ` Simon Glass
2017-04-08 12:50 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:50 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:42 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:42 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:33 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:33 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:30 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:30 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:26 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:26 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:18 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:18 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-08 12:17 [U-Boot] [PATCH 0/5] Eric Gao
2017-04-08 12:17 ` [U-Boot] [PATCH 1/5] rockchip: i2c: enable i2c for rk3399 Eric Gao
2017-04-09 19:28   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58EB022D.1050606@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox