From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D53C61DA4 for ; Mon, 6 Feb 2023 14:56:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5F95685BF7; Mon, 6 Feb 2023 15:56:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="Wo86A50R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E99285BF8; Mon, 6 Feb 2023 15:56:29 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20620.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::620]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BECF085BF2; Mon, 6 Feb 2023 15:56:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFcBzWZPTElCPYKOUxMw179DPw7wymMMhtg9r4IWyLHxQGuTfzOY6fajQAE/p2YvNmlCQQ5dtvsJkdkea1OrvzFzWqK213T9CqD7ydFMGTfIhP3A8bxanlDc+FDKvZsMAN3hnsViJ3yYjMvqslVUDBvluoOt619919bJEq9wqlpdLJohfiJ/lr+pq4+SCfoyywEBaC6gZSB4qmV5C5VMGCSUkcuAueZVe2LBgorE5lyPjIYEjwazL8WcjfOKygrZYpTq+E+dbUixNbh/qoQ4ybL7TeN4CrFNHq+2A6fOk3iDn/Irpr0JHTHvZ9V1VktZx8nJ4zTXaYBC13Ybo+opEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZEKYtENYa5y1oRUlVGHTyDvgVMS+gPgHBF4MkU+u7Ts=; b=PPwsPUTO09+TJOu6X6bED8/6MxU4CQ6aia3GTExoQv5BcTKMkAB4GXuHFbso/n6N4XdT5MmKxENK+G4Q9YbgMpUVkwt8IY6OrFYaSPOvl8+74Lmpjq+Ff1hxwft8GLcpplZXB40GEK7hptuNBIEk/IbrA27iYgzJGvFulMKQRTYThhNup6t/UdxJ+9hld1gjUOG0xa6H76yB6kQW//uLdS/qgfwQ5KZ43E+LkHBlrWofL4/bp/MFhZJjpGNkxzr8n1wQwuPH/unHLlMB7/N9aJaDjRpmk1egc4FEpqWDftA1e7pdK98H9lo+7mIbKu4wD6brv/6BcsqI6TtKDhFXzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=konsulko.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEKYtENYa5y1oRUlVGHTyDvgVMS+gPgHBF4MkU+u7Ts=; b=Wo86A50RopBg3yu7atBBCeDYMt0u+L3xbMMIQZgU7HZukmTTSrvyoZRFxPheVQ97+zmZiD7NFPr9QhtbDDMCXc/6XcyAnKy/plmtFadah7mSIpUK5sMyx+5mlnXf7t45Ogl9YGOOrNHToe4CL2srixGv7ukIITGphrRIzzvm3JI= Received: from MW4PR04CA0368.namprd04.prod.outlook.com (2603:10b6:303:81::13) by IA1PR12MB8405.namprd12.prod.outlook.com (2603:10b6:208:3d8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:56:20 +0000 Received: from CO1NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::87) by MW4PR04CA0368.outlook.office365.com (2603:10b6:303:81::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:56:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT078.mail.protection.outlook.com (10.13.175.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:56:20 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 08:56:17 -0600 Message-ID: <5919786f-354d-7d7f-d2a7-19f0b7121a0c@amd.com> Date: Mon, 6 Feb 2023 15:56:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Tom Rini CC: Simon Glass , , U-Boot Custodians References: <20230201225428.2001161-1-sjg@chromium.org> <20230201225428.2001161-7-sjg@chromium.org> From: Michal Simek Subject: Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT078:EE_|IA1PR12MB8405:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b2cc4cd-a432-4f2c-2369-08db08524ecb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QcMTopnvQMgn8EqfrjcjNIRC4H6aEwR22ePIww9s62KLJFZeGUaqEYZTCFjNHL1ESF4ai0dX2pBMtZv4cwwDbzT0FEMcCy1VQs+wjCDocMH/3/Ul51HPzGXoDw5CSlzQ5Y3bRU7S1qDD6uonqEBadYLDmLnrscgOhRQEkCE7DsWd8NaR8DZ+8EWq/1B17ayA/SocPyW+ptBhp/w0Oak1cdQWo0L3BgJF8d+9PlLOGJPu7nDp80vB//iNcEHLkcqh8mTb6yGHYFTdwM2L5uTPmqHrD9C/HFvUFvB3eCABsU+e/5/uAKntrayIGLXvGNYgSXSWrw10VhWdqkmaSw/p4SP3ODaNk+NbhESmC4dgCvXdijAHiZo6g+j53nxIBumrm1Gx44fJstAmelFJ3+2N0M9A6dkFW61DP9HgDLQpF6v26QvFRQQZBj0yQSFj5TqtEAS0CohX5qpaMonkzk7KMC69ATvqvkZzu5ikLFJ9lb6x7KFKcmVzc+gb1OLzq5Ho/u2inibupcKKO5Z5oRYG29fS05zRhybk+wlVakekGZNnMtm/CA8FfOfIwZ3bLjjtIzm+2yoefpCclK6S8sx9V+8YuPqFCMW4N5+51sujYj/2+KCxwovP0f+X5/DC+JfEfcQZNKm0dhBi7q/wr4BhYmigHNQXOEsUyvP/0QeJufUqvFN69KoUknRMBmPbLuaxYkWnIkmplhZdpq8+gd1Nt/iTq0fBbgUZ+pAFFCDJigStCeKvjOU48nM01NhUdnUoAJAveAXFnozlHI4+4sKxJ8eQf6HTpXjETMwFqSvAwEk= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(36840700001)(46966006)(40470700004)(36756003)(31696002)(40460700003)(86362001)(81166007)(316002)(8676002)(4326008)(70586007)(70206006)(6916009)(16576012)(478600001)(54906003)(82310400005)(8936002)(5660300002)(41300700001)(40480700001)(2906002)(36860700001)(47076005)(82740400003)(44832011)(186003)(53546011)(16526019)(26005)(966005)(6666004)(426003)(83380400001)(336012)(2616005)(356005)(31686004)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:56:20.3614 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2cc4cd-a432-4f2c-2369-08db08524ecb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8405 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/6/23 15:44, Tom Rini wrote: > On Mon, Feb 06, 2023 at 01:22:48PM +0100, Michal Simek wrote: >> Hi Simon, >> >> On 2/1/23 23:54, Simon Glass wrote: >>> Update various build and test components to use the new schema. >>> >>> Signed-off-by: Simon Glass >>> --- >>> >>> (no changes since v1) >>> >>> drivers/core/ofnode.c | 10 +++++----- >>> drivers/video/video-uclass.c | 4 ++-- >>> dts/Kconfig | 2 +- >>> include/dm/device.h | 2 +- >>> include/dm/ofnode.h | 10 +++++----- >>> scripts/Makefile.lib | 12 ++++++------ >>> test/dm/test-fdt.c | 2 +- >>> test/py/tests/test_ofplatdata.py | 8 ++++---- >>> tools/binman/binman.rst | 3 +-- >>> tools/dtoc/test_fdt.py | 8 ++++---- >>> 10 files changed, 30 insertions(+), 31 deletions(-) >>> >>> diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c >>> index 4d56b1a7675..5249a60639b 100644 >>> --- a/drivers/core/ofnode.c >>> +++ b/drivers/core/ofnode.c >>> @@ -1265,22 +1265,22 @@ bool ofnode_pre_reloc(ofnode node) >>> { >>> #if defined(CONFIG_SPL_BUILD) || defined(CONFIG_TPL_BUILD) >>> /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass >>> - * had property dm-pre-reloc or u-boot,dm-spl/tpl. >>> + * had property bootph-all or bootph-pre-sram/bootph-pre-ram. >>> * They are removed in final dtb (fdtgrep 2nd pass) >>> */ >>> return true; >>> #else >>> - if (ofnode_read_bool(node, "u-boot,dm-pre-reloc")) >>> + if (ofnode_read_bool(node, "bootph-all")) >>> return true; >>> - if (ofnode_read_bool(node, "u-boot,dm-pre-proper")) >>> + if (ofnode_read_bool(node, "bootph-some-ram")) >>> return true; >>> /* >>> * In regular builds individual spl and tpl handling both >>> * count as handled pre-relocation for later second init. >>> */ >>> - if (ofnode_read_bool(node, "u-boot,dm-spl") || >>> - ofnode_read_bool(node, "u-boot,dm-tpl")) >>> + if (ofnode_read_bool(node, "bootph-pre-ram") || >>> + ofnode_read_bool(node, "bootph-pre-sram")) >>> return true; >> >> Please correct me if I am wrong but this change will likely break all boards >> which didn't migrate to this at this stage. And because targeting early >> stages people will be without console. >> I think we should have transition period for 1-2 releases to give people >> enough time to migrate. It means print big warning that they have to migrate >> their DTS. > > What's the migration case here we're missing? Is it platforms that > maintain a dts externally, via tooling / etc, that populate those nodes? Yes and I expect there will be a lot of DTs around with some changes for specific products. Also for example QEMU is also generating DT based on it's configuration and provide it to U-Boot. https://gitlab.com/qemu-project/qemu/-/blob/master/hw/arm/xlnx-versal-virt.c#L91 When this patch is applied CI loop should fail for Versal. Thanks, Michal