From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ziyuan Date: Tue, 16 May 2017 10:22:05 +0800 Subject: [U-Boot] [PATCH 01/33] mmc: select the available type from host_caps and card_caps In-Reply-To: <9dcd15a4-12b9-459a-de46-93a8062a7362@samsung.com> References: <1494828447-24332-1-git-send-email-xzy.xu@rock-chips.com> <591A52C6.7020906@rock-chips.com> <9dcd15a4-12b9-459a-de46-93a8062a7362@samsung.com> Message-ID: <591A624D.6050804@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de hi Jaehoon, On 05/16/2017 09:55 AM, Jaehoon Chung wrote: > Hi Ziyuan, > > On 05/16/2017 10:15 AM, Ziyuan wrote: >> hi Simon & Jaehoon, >> >> On 05/16/2017 08:18 AM, Simon Glass wrote: >>> Hi Ziyuan, >>> >>> On 15 May 2017 at 00:06, Ziyuan Xu wrote: >>>> The original implementation select HS timing by default, add available >>>> type selection for higher speed mode compatibility, such as hs200, >>>> hs400, hs400es. >>>> >>>> By the way, we assume that card run at 1.8V or 1.2V I/O when its timing >>>> is ddr52/hs200/hs400(es). >>>> >>>> Signed-off-by: Ziyuan Xu >>>> --- >>>> >>>> drivers/mmc/mmc.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- >>>> include/mmc.h | 16 +++++++++++++++ >>>> 2 files changed, 74 insertions(+), 1 deletion(-) >>>> >>> Is there a cover letter for this series, please? >> This patchset is used for hs200/hs400/ddr52 mode of eMMC device, and fixes some bug for dw_mmc & sdhci controller. >> It's only valid in U-Boot stage, we still use 'High Speed' in SPL. >> >> I tested it on evb-rk3288 board(eMMC 4.5) and evb-rk3388 board(eMMC 5.0). >>> I just reviewed an MMC series at add higher speed support. I'm not >>> sure but I suspect these overlap. >> Ha, I just reviewed Vignesh's patches, it focuses on uhs mode of sd card. It looks to me. >> But some details are not the same as mine. Anyway, what do you think? > I didn't review both yet..After checking, i will share my opinion. how about? Fine, I look forward to your opinion. > >>> Regards, >>> Simon >>> >>> >>> >> >> >> >> > > >