public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/47] Kconfig: Drop CONFIG_CMD_DS4510_INFO
Date: Tue, 16 May 2017 05:29:37 +0200	[thread overview]
Message-ID: <591A7221.2080207@denx.de> (raw)
In-Reply-To: <20170515105802.23023-3-sjg@chromium.org>

Hello Simon,

Am 15.05.2017 um 12:57 schrieb Simon Glass:
> This option is only used in one driver and two boards. It does not seem
> worth having the ability to remove this part of the support.
>
> Drop the option.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   README                        | 1 -
>   drivers/misc/ds4510.c         | 8 --------
>   include/configs/xpedite517x.h | 1 -
>   include/configs/xpedite537x.h | 1 -
>   scripts/config_whitelist.txt  | 1 -
>   5 files changed, 12 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/README b/README
> index 2ca0102b57..3c4f0165b1 100644
> --- a/README
> +++ b/README
> @@ -831,7 +831,6 @@ The following options need to be configured:
>   		CONFIG_CMD_DHCP		* DHCP support
>   		CONFIG_CMD_DIAG		* Diagnostics
>   		CONFIG_CMD_DS4510	* ds4510 I2C gpio commands
> -		CONFIG_CMD_DS4510_INFO	* ds4510 I2C info command
>   		CONFIG_CMD_DS4510_MEM	* ds4510 I2C eeprom/sram commansd
>   		CONFIG_CMD_DS4510_RST	* ds4510 I2C rst command
>   		CONFIG_CMD_DTT		* Digital Therm and Thermostat
> diff --git a/drivers/misc/ds4510.c b/drivers/misc/ds4510.c
> index d7c9bd73c8..940e2ce6a0 100644
> --- a/drivers/misc/ds4510.c
> +++ b/drivers/misc/ds4510.c
> @@ -186,7 +186,6 @@ int ds4510_gpio_read_val(uint8_t chip)
>   }
>
>   #ifdef CONFIG_CMD_DS4510
> -#ifdef CONFIG_CMD_DS4510_INFO
>   /*
>    * Display DS4510 information
>    */
> @@ -240,7 +239,6 @@ static int ds4510_info(uint8_t chip)
>
>   	return 0;
>   }
> -#endif /* CONFIG_CMD_DS4510_INFO */
>
>   cmd_tbl_t cmd_ds4510[] = {
>   	U_BOOT_CMD_MKENT(device, 3, 0, (void *)DS4510_CMD_DEVICE, "", ""),
> @@ -248,9 +246,7 @@ cmd_tbl_t cmd_ds4510[] = {
>   	U_BOOT_CMD_MKENT(output, 4, 0, (void *)DS4510_CMD_OUTPUT, "", ""),
>   	U_BOOT_CMD_MKENT(input, 3, 0, (void *)DS4510_CMD_INPUT, "", ""),
>   	U_BOOT_CMD_MKENT(pullup, 4, 0, (void *)DS4510_CMD_PULLUP, "", ""),
> -#ifdef CONFIG_CMD_DS4510_INFO
>   	U_BOOT_CMD_MKENT(info, 2, 0, (void *)DS4510_CMD_INFO, "", ""),
> -#endif
>   #ifdef CONFIG_CMD_DS4510_RST
>   	U_BOOT_CMD_MKENT(rstdelay, 3, 0, (void *)DS4510_CMD_RSTDELAY, "", ""),
>   #endif
> @@ -324,10 +320,8 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>   		else
>   			tmp &= ~(1 << ul_arg2);
>   		return ds4510_pullup_write(chip, tmp);
> -#ifdef CONFIG_CMD_DS4510_INFO
>   	case DS4510_CMD_INFO:
>   		return ds4510_info(chip);
> -#endif
>   #ifdef CONFIG_CMD_DS4510_RST
>   	case DS4510_CMD_RSTDELAY:
>   		return ds4510_rstdelay_write(chip, ul_arg2);
> @@ -378,10 +372,8 @@ U_BOOT_CMD(
>   	"ds4510 eeprom/seeprom/sram/gpio access",
>   	"device [dev]\n"
>   	"	- show or set current device address\n"
> -#ifdef CONFIG_CMD_DS4510_INFO
>   	"ds4510 info\n"
>   	"	- display ds4510 info\n"
> -#endif
>   	"ds4510 output pin 0|1\n"
>   	"	- set pin low or high-Z\n"
>   	"ds4510 input pin\n"
> diff --git a/include/configs/xpedite517x.h b/include/configs/xpedite517x.h
> index 447fd9557a..dae61b11e4 100644
> --- a/include/configs/xpedite517x.h
> +++ b/include/configs/xpedite517x.h
> @@ -503,7 +503,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
>    * Command configuration.
>    */
>   #define CONFIG_CMD_DS4510
> -#define CONFIG_CMD_DS4510_INFO
>   #define CONFIG_CMD_DTT
>   #define CONFIG_CMD_EEPROM
>   #define CONFIG_CMD_IRQ
> diff --git a/include/configs/xpedite537x.h b/include/configs/xpedite537x.h
> index 48f07b08c0..ce1ff86135 100644
> --- a/include/configs/xpedite537x.h
> +++ b/include/configs/xpedite537x.h
> @@ -355,7 +355,6 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy);
>    * Command configuration.
>    */
>   #define CONFIG_CMD_DS4510
> -#define CONFIG_CMD_DS4510_INFO
>   #define CONFIG_CMD_DTT
>   #define CONFIG_CMD_EEPROM
>   #define CONFIG_CMD_JFFS2
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 7646bb6842..b4c3d6b311 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -385,7 +385,6 @@ CONFIG_CMDLINE_EDITING
>   CONFIG_CMDLINE_PS_SUPPORT
>   CONFIG_CMDLINE_TAG
>   CONFIG_CMD_DS4510
> -CONFIG_CMD_DS4510_INFO
>   CONFIG_CMD_DS4510_MEM
>   CONFIG_CMD_DS4510_RST
>   CONFIG_CMD_DTT
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2017-05-16  3:29 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 10:57 [U-Boot] [PATCH 00/47] Kconfig: Convert commands (D to L) to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 01/47] configs: Re-sync Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 02/47] Kconfig: Drop CONFIG_CMD_DS4510_INFO Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:29   ` Heiko Schocher [this message]
2017-05-15 10:57 ` [U-Boot] [PATCH 03/47] Kconfig: Drop CONFIG_CMD_DS4510_MEM Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 04/47] Kconfig: Drop CONFIG_CMD_DS4510_RST Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 05/47] Kconfig: Drop CONFIG_CMD_DS4510 Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 06/47] Convert CONFIG_DS4510 to Kconfig Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:31   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 07/47] Kconfig: Drop CONFIG_SYS_I2C_DTT_ADDR Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:31   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 08/47] Drop three-wire serial (TWS) support Simon Glass
2017-05-15 16:32   ` Tom Rini
2017-05-15 17:13     ` Anatolij Gustschin
2017-05-15 10:57 ` [U-Boot] [PATCH 09/47] Drop digital thermometer and thermostat (DTT) drivers Simon Glass
2017-05-15 16:59   ` Tom Rini
2017-05-16  0:17     ` Simon Glass
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 10/47] Kconfig: Drop CONFIG_SYS_I2C_DS1621_ADDR Simon Glass
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 11/47] Kconfig: Drop CONFIG_SYS_I2C_DS4510_ADDR Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 12/47] Convert CONFIG_CMD_ECCTEST to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 13/47] Convert CONFIG_CMD_EECONFIG " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 14/47] Convert CONFIG_CMD_EEPROM et al " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:54       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 15/47] Convert CONFIG_CMD_ENTERRCM " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 16/47] Convert CONFIG_CMD_ENV " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 17/47] Convert CONFIG_CMD_ENV_CALLBACK " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 18/47] Convert CONFIG_CMD_ENV_FLAGS " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 19/47] Convert CONFIG_CMD_ERRATA " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 20/47] Convert CONFIG_CMD_ESBC_VALIDATE " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 21/47] Convert CONFIG_CMD_ETHSW " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 22/47] Convert CONFIG_CMD_FDC " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 23/47] Kconfig: Drop CONFIG_CMD_FDT_MAX_DUMP Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 24/47] Convert CONFIG_CMD_FPGAD to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 25/47] Convert CONFIG_CMD_FPGA_LOADBP et al " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 26/47] Convert CONFIG_CMD_FUSE " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 27/47] Convert CONFIG_CMD_GETTIME " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 28/47] Convert CONFIG_CMD_GSC " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 29/47] Convert CONFIG_CMD_HASH " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-17  1:34     ` Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 30/47] Kconfig: Add CONFIG_HASH to enable hashing API Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 31/47] Convert CONFIG_CMD_HD44760 to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 32/47] Convert CONFIG_CMD_HDMIDETECT " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:48       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 33/47] Convert CONFIG_CMD_IDE " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:45       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 34/47] Kconfig: Add a CONFIG_IDE option Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 35/47] Convert CONFIG_CMD_IMMAP to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 36/47] Kconfig: Drop CONFIG_CMD_IMXOTP Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 37/47] Kconfig: Drop CONFIG_CMD_IMX_FUSE Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 38/47] Convert CONFIG_CMD_IO to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 39/47] Convert CONFIG_CMD_IOLOOP " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 40/47] Convert CONFIG_CMD_IOTRACE " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 41/47] Convert CONFIG_CMD_JFFS2 " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 42/47] fs: Kconfig: Add a separate option for FS_JFFS2 Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 43/47] Convert CONFIG_CMD_IRQ to Kconfig Simon Glass
2017-05-15 18:05   ` Tom Rini
2017-05-16 11:24   ` Daniel Schwierzeck
2017-05-15 10:57 ` [U-Boot] [PATCH 44/47] Convert CONFIG_CMD_KGDB " Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 45/47] Kconfig: Drop CONFIG_CMD_LOADY Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 46/47] Convert CONFIG_LZMA to Kconfig Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 47/47] Convert CONFIG_CMD_LZMADEC " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591A7221.2080207@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox