[U-Boot] [PATCH 04/47] Kconfig: Drop CONFIG_CMD_DS4510_RST

Heiko Schocher
2017-05-16T03:30:24Z

Hello Simon,

Am 15.05.2017 um 12:57 schrieb Simon Glass:
> This option is only used in one driver and is not enabled by any board. It
> does not seem worth having the ability to remove this part of the support.
>
> Drop the option.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> README | 1 -
> drivers/misc/ds4510.c | 6 ------
> scripts/config_whitelist.txt | 1 -
> 3 files changed, 8 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/README b/README
> index 965fc9c7eb..c3f4824f64 100644
> --- a/README
> +++ b/README
> @@ -831,7 +831,6 @@ The following options need to be configured:
> CONFIG_CMD_DHCP * DHCP support
> CONFIG_CMD_DIAG * Diagnostics
> CONFIG_CMD_DS4510 * ds4510 I2C gpio commands
> - CONFIG_CMD_DS4510_RST * ds4510 I2C rst command
> CONFIG_CMD_DTT * Digital Therm and Thermostat
> CONFIG_CMD_ECHO echo arguments
> CONFIG_CMD_EDITENV edit env variable
> diff --git a/drivers/misc/ds4510.c b/drivers/misc/ds4510.c
> index 936fb3ead4..c08a0bee63 100644
> --- a/drivers/misc/ds4510.c
> +++ b/drivers/misc/ds4510.c
> @@ -247,9 +247,7 @@ cmd_tbl_t cmd_ds4510[] = {
> U_BOOT_CMD_MKENT(input, 3, 0, (void *)DS4510_CMD_INPUT, "", ""),
> U_BOOT_CMD_MKENT(pullup, 4, 0, (void *)DS4510_CMD_PULLUP, "", ""),
> U_BOOT_CMD_MKENT(info, 2, 0, (void *)DS4510_CMD_INFO, "", ""),
> -#ifdef CONFIG_CMD_DS4510_RST
> U_BOOT_CMD_MKENT(rstdelay, 3, 0, (void *)DS4510_CMD_RSTDELAY, "", ""),
> -#endif
> U_BOOT_CMD_MKENT(eeprom, 6, 0, (void *)DS4510_CMD_EEPROM, "", ""),
> U_BOOT_CMD_MKENT(seeprom, 6, 0, (void *)DS4510_CMD_SEEPROM, "", ""),
> U_BOOT_CMD_MKENT(sram, 6, 0, (void *)DS4510_CMD_SRAM, "", ""),
> @@ -318,10 +316,8 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> return ds4510_pullup_write(chip, tmp);
> case DS4510_CMD_INFO:
> return ds4510_info(chip);
> -#ifdef CONFIG_CMD_DS4510_RST
> case DS4510_CMD_RSTDELAY:
> return ds4510_rstdelay_write(chip, ul_arg2);
> -#endif
> case DS4510_CMD_EEPROM:
> end = DS4510_EEPROM + DS4510_EEPROM_SIZE;
> off = DS4510_EEPROM;
> @@ -374,11 +370,9 @@ U_BOOT_CMD(
> " - disable/enable pullup on specified pin\n"
> "ds4510 nv 0|1\n"
> " - make gpio and seeprom writes volatile/non-volatile"
> -#ifdef CONFIG_CMD_DS4510_RST
> "\n"
> "ds4510 rstdelay 0-3\n"
> " - set reset output delay"
> -#endif
> "\n"
> "ds4510 eeprom read addr off cnt\n"
> "ds4510 eeprom write addr off cnt\n"
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 5e3cd98d44..17f241720a 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -385,7 +385,6 @@ CONFIG_CMDLINE_EDITING
> CONFIG_CMDLINE_PS_SUPPORT
> CONFIG_CMDLINE_TAG
> CONFIG_CMD_DS4510
> -CONFIG_CMD_DS4510_RST
> CONFIG_CMD_DTT
> CONFIG_CMD_ECCTEST
> CONFIG_CMD_EECONFIG
>

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany