From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C02C5C61DA4 for ; Thu, 9 Feb 2023 16:33:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8824D85E1C; Thu, 9 Feb 2023 17:33:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675960404; bh=7C242DRsu6P8xCNf7ErabtL5NBMm1hib3cNWi3mRLZY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BHpiqUNrrLJuygo3GOefpGRFXSnIpeCYHOXTuELJhcHgUjrm+MHloclgMqlxJaJLf aCcIrWYm37qp9USxyXYYrscptAxpOfDSqSl6DDvsh92JLSIyOkntYBMpjHj264t42a YVu5H4OAN6xO0/ApZOHJVKdY2cvCgRiEP1ezW8v64ggcW1Rllk36rurCTbf7d1+BGZ gVPo2gNdsrTNZs9Gr6a+Lkn71afnj/KY60VPrymALMNtAXIZX0YCotQwf4r0PjtlB3 B1dkIoUxmWl5Hh/RMRROsPDKCKXMxcsGxtQajAGyw+jMFhkNn6CKehBMx1NzI3yC51 4nb60iIKJKELQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 629E8858C7; Thu, 9 Feb 2023 17:33:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675960401; bh=7C242DRsu6P8xCNf7ErabtL5NBMm1hib3cNWi3mRLZY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=xOR3L0/rZIEs7E9ILHl5OPTJC/S8+tqSDqV11n4ttpjKohRAMlfBVPgjGsBlWoXA4 GDso7qzd9PgRwTwlSAu+OMLiP68l5lrmcXoYT7GqzeQUMC1AqY6FGTMESJ7vVO++Fc KopQT1JyD5jTfE1klxdu58d9Bq+yVa3jLd/W211yV7JPIWjEVrNCNj79VKrpkX2wPT 1G/PkiBPfRA5SHD0NNRgnYzTvD+dZPZnUvxmsNfbXQRWj8HQHaMKs/545g1WhtsWZF NqvYSWg8130eg7SZqgm4R+8H7A7xKHIK8AY2SlEsEmBfjb6x0R9YXciXtyfMwZLSiM cCy/OE9mjVQKQ== Message-ID: <5931e98e-30c5-a0b8-07dc-1f8b75155bc6@denx.de> Date: Thu, 9 Feb 2023 17:33:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 2/2] env: mmc: Apply GPT only on eMMC user HW partition To: Tom Rini Cc: u-boot@lists.denx.de, Patrice Chotard , Patrick Delaunay References: <20230209123010.31953-1-marex@denx.de> <20230209123010.31953-2-marex@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/9/23 16:27, Tom Rini wrote: > On Thu, Feb 09, 2023 at 01:30:10PM +0100, Marek Vasut wrote: > >> Apply the GPT U-Boot environment GUID type look up only on eMMC user >> HW partition, do not apply the look up on eMMC boot HW partitions as >> mmc_offset_try_partition() assumes either SD partitions or eMMC user >> HW partition. >> >> This fixes environment operation on systems where CONFIG_SYS_MMC_ENV_PART >> is non-zero and CONFIG_SYS_REDUNDAND_ENVIRONMENT is set. >> >> Fixes: 80105d8fd52 ("env: mmc: select GPT env partition by type guid") >> Signed-off-by: Marek Vasut > > So you're saying that today, you cannot make use of this feature and put > the environment on one of the boot partitions, as it doesn't work? Today you cannot place env into GPT which is located in eMMC BOOT HW partitions, that only works for GPT which is located in eMMC USER HW partition. > If > so, then yes, this is the first step forward and someone else with that > wants the case I described here can fix things further. I'm not even sure whether it makes sense to have 4 MiB or so GPT in eMMC BOOT HW partitions in the first place, but sure, if someone needs that at some later point, why not. > Reviewed-by: Tom Rini