public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs: usbifs: Fix warning in ubifs
Date: Tue, 6 Jun 2017 07:10:43 +0200	[thread overview]
Message-ID: <59363953.2070703@denx.de> (raw)
In-Reply-To: <854c3261ff41183566d44728b6a8e604e3f14980.1496147344.git.michal.simek@xilinx.com>

Hello Michal,

Am 30.05.2017 um 14:29 schrieb Michal Simek:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> This patch fixes the below warning by typecasting it properly
> fs/ubifs/ubifs.c: In function 'ubifs_load':
> fs/ubifs/ubifs.c:942:29: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
>    err = ubifs_read(filename, (void *)addr, 0, size, &actread);
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   fs/ubifs/ubifs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
> index cc397d605b0e..db29489eca75 100644
> --- a/fs/ubifs/ubifs.c
> +++ b/fs/ubifs/ubifs.c
> @@ -939,7 +939,7 @@ int ubifs_load(char *filename, u32 addr, u32 size)
>
>   	printf("Loading file '%s' to addr 0x%08x...\n", filename, addr);
>
> -	err = ubifs_read(filename, (void *)addr, 0, size, &actread);
> +	err = ubifs_read(filename, (void *)(uintptr_t)addr, 0, size, &actread);
>   	if (err == 0) {
>   		setenv_hex("filesize", actread);
>   		printf("Done\n");
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2017-06-06  5:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 12:29 [U-Boot] [PATCH] fs: usbifs: Fix warning in ubifs Michal Simek
2017-06-06  5:10 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59363953.2070703@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox