From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 9 Jun 2017 17:55:10 +0200 Subject: [U-Boot] [U-Boot, v2, 4/4] arm: am33xx: Add support for mulitiple PLL input frequencies In-Reply-To: <20170609112046.GA10782@bill-the-cat> References: <20170505072910.20772-5-lokeshvutla@ti.com> <20170512172050.GT5701@bill-the-cat> <20170607205006.68b4780d28b90c1dfd9c12fe@bidouilliste.com> <7ef0d989-49bd-ef37-e7f1-a835caa9b520@ti.com> <20170609004521.GU10782@bill-the-cat> <593A1D51.5070505@denx.de> <593A76F4.8040504@denx.de> <20170609112046.GA10782@bill-the-cat> Message-ID: <593AC4DE.5020600@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Am 09.06.2017 um 13:20 schrieb Tom Rini: > On Fri, Jun 09, 2017 at 12:22:44PM +0200, Heiko Schocher wrote: >> Hello Lokesh, >> >> Am 09.06.2017 um 11:25 schrieb Lokesh Vutla: >>> >>> >>> On Friday 09 June 2017 09:30 AM, Heiko Schocher wrote: >>>> Hello Tom, >>>> >>>> Am 09.06.2017 um 02:45 schrieb Tom Rini: >>>>> On Thu, Jun 08, 2017 at 10:17:09AM +0530, Lokesh Vutla wrote: >>>>>> >>>>>> >>>>>> On Thursday 08 June 2017 12:20 AM, Emmanuel Vadot wrote: >>>>>>> On Fri, 12 May 2017 13:20:50 -0400 >>>>>>> Tom Rini wrote: >>>>>>> >>>>>>>> On Fri, May 05, 2017 at 12:59:10PM +0530, Lokesh Vutla wrote: >>>>>>>> >>>>>>>>> am335x supports various sysclk frequencies which can be determined >>>>>>>>> using sysboot pins. PLLs should be configures based on this >>>>>>>>> sysclk frequency. Add PLL configurations for all supported >>>>>>>>> frequencies. >>>>>>>>> >>>>>>>>> Signed-off-by: Lokesh Vutla >>>>>>>>> Reviewed-by: Tom Rini >>>>>>>> >>>>>>>> Applied to u-boot/master, thanks! >>>>>>>> >>>>>>>> -- >>>>>>>> Tom >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> This appears to break beaglebone black support, reverting this commit >>>>>>> make u-boot works again. >>>>>> >>>>>> hmm..I see the problem. Here we are hard coding MPU freq to 1GHz even >>>>>> efuse say it is not supported(I am not sure why this is being done, may >>>>>> be Tom can give more details). Even in kernel I see that cpufreq is >>>>>> reading efuse to determine mpu frequency. Now that we have jitter >>>>>> optimized pll configurations, looks like unsupported freq is causing an >>>>>> issue. Can you see if the below patch helps? >>>>> >>>>> Well, in the kernel, did anyone poke the Beagleboard folks about this, >>>>> before pushing the change? There's BBB shipping with chips that did not >>>>> have their efuses set, hence the way things were structured in U-Boot. >>>> >>>> I have runnint tbot tests on a BBB [1] ... and yes, currently test >>>> is red = bad ... :-( >>>> >>>> Not sure, if it is this patch ... >>> >>> Yeah, I don't think this is the patch causing the issue. AM335x-evm >>> boots fine for me. There are similar boot failures reported[1] on NVIDIA >>> platforms as well. Not sure if we are hitting the same issue. Ill did >>> more into this and update you guys. >>> >>> [1] https://www.mail-archive.com/u-boot at lists.denx.de/msg252698.html >> >> Time for using tbot and automated git bisect testcase ;-) > > How do you have the BBB configured such that you can recover it from a > bad U-Boot, automatically? Thanks! That;s exactly the reason, why I did not started a "git bisect", as this is not solved for the BBB in our lab. Wolfgang bought such a Airflash card, but we did not found time to try it. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany