From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
Date: Mon, 26 Jun 2017 07:14:55 +0200 [thread overview]
Message-ID: <5950984F.9020102@denx.de> (raw)
In-Reply-To: <1498117882-21695-1-git-send-email-yamada.masahiro@socionext.com>
Hello Masahiro,
Am 22.06.2017 um 09:51 schrieb Masahiro Yamada:
> These are only used in drivers/mis/i2c_eeprom.c
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/misc/i2c_eeprom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c
> index da6e2b05f730..a14e83225bcc 100644
> --- a/drivers/misc/i2c_eeprom.c
> +++ b/drivers/misc/i2c_eeprom.c
> @@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset,
> return -ENODEV;
> }
>
> -struct i2c_eeprom_ops i2c_eeprom_std_ops = {
> +static const struct i2c_eeprom_ops i2c_eeprom_std_ops = {
> .read = i2c_eeprom_std_read,
> .write = i2c_eeprom_std_write,
> };
> @@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev)
> return 0;
> }
>
> -int i2c_eeprom_std_probe(struct udevice *dev)
> +static int i2c_eeprom_std_probe(struct udevice *dev)
> {
> return 0;
> }
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2017-06-26 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 7:51 [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe Masahiro Yamada
2017-06-22 8:22 ` Bin Meng
2017-06-26 5:14 ` Heiko Schocher [this message]
2017-07-07 3:57 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5950984F.9020102@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox