* [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
@ 2017-06-22 7:51 Masahiro Yamada
2017-06-22 8:22 ` Bin Meng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2017-06-22 7:51 UTC (permalink / raw)
To: u-boot
These are only used in drivers/mis/i2c_eeprom.c
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/misc/i2c_eeprom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c
index da6e2b05f730..a14e83225bcc 100644
--- a/drivers/misc/i2c_eeprom.c
+++ b/drivers/misc/i2c_eeprom.c
@@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset,
return -ENODEV;
}
-struct i2c_eeprom_ops i2c_eeprom_std_ops = {
+static const struct i2c_eeprom_ops i2c_eeprom_std_ops = {
.read = i2c_eeprom_std_read,
.write = i2c_eeprom_std_write,
};
@@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev)
return 0;
}
-int i2c_eeprom_std_probe(struct udevice *dev)
+static int i2c_eeprom_std_probe(struct udevice *dev)
{
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
2017-06-22 7:51 [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe Masahiro Yamada
@ 2017-06-22 8:22 ` Bin Meng
2017-06-26 5:14 ` Heiko Schocher
2017-07-07 3:57 ` Simon Glass
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2017-06-22 8:22 UTC (permalink / raw)
To: u-boot
On Thu, Jun 22, 2017 at 3:51 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> These are only used in drivers/mis/i2c_eeprom.c
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/misc/i2c_eeprom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
2017-06-22 7:51 [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe Masahiro Yamada
2017-06-22 8:22 ` Bin Meng
@ 2017-06-26 5:14 ` Heiko Schocher
2017-07-07 3:57 ` Simon Glass
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2017-06-26 5:14 UTC (permalink / raw)
To: u-boot
Hello Masahiro,
Am 22.06.2017 um 09:51 schrieb Masahiro Yamada:
> These are only used in drivers/mis/i2c_eeprom.c
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/misc/i2c_eeprom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c
> index da6e2b05f730..a14e83225bcc 100644
> --- a/drivers/misc/i2c_eeprom.c
> +++ b/drivers/misc/i2c_eeprom.c
> @@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset,
> return -ENODEV;
> }
>
> -struct i2c_eeprom_ops i2c_eeprom_std_ops = {
> +static const struct i2c_eeprom_ops i2c_eeprom_std_ops = {
> .read = i2c_eeprom_std_read,
> .write = i2c_eeprom_std_write,
> };
> @@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev)
> return 0;
> }
>
> -int i2c_eeprom_std_probe(struct udevice *dev)
> +static int i2c_eeprom_std_probe(struct udevice *dev)
> {
> return 0;
> }
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
2017-06-22 7:51 [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe Masahiro Yamada
2017-06-22 8:22 ` Bin Meng
2017-06-26 5:14 ` Heiko Schocher
@ 2017-07-07 3:57 ` Simon Glass
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2017-07-07 3:57 UTC (permalink / raw)
To: u-boot
On 22 June 2017 at 01:51, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> These are only used in drivers/mis/i2c_eeprom.c
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/misc/i2c_eeprom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-07 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-22 7:51 [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe Masahiro Yamada
2017-06-22 8:22 ` Bin Meng
2017-06-26 5:14 ` Heiko Schocher
2017-07-07 3:57 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox