* [U-Boot] [PATCH] km/common: remove unused code
@ 2017-06-30 13:33 Holger Brunck
2017-06-30 13:52 ` Heiko Schocher
2017-07-07 11:41 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Holger Brunck @ 2017-06-30 13:33 UTC (permalink / raw)
To: u-boot
The 82xx board mgcoge3ne was removed from the codebase, so this is dead
code.
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Cc: Heiko Schocher <hs@denx.de>
---
board/keymile/common/common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index 0829b7fa06..408079c9a1 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -355,9 +355,6 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
#if defined(CONFIG_POST)
testpin = post_hotkeys_pressed();
#endif
-#if defined(CONFIG_MGCOGE3NE)
- testpin = get_testpin();
-#endif
s = getenv("test_bank");
/* when test_bank is not set, act as if testpin is not asserted */
testboot = (testpin != 0) && (s);
--
2.12.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] km/common: remove unused code
2017-06-30 13:33 [U-Boot] [PATCH] km/common: remove unused code Holger Brunck
@ 2017-06-30 13:52 ` Heiko Schocher
2017-07-07 11:41 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2017-06-30 13:52 UTC (permalink / raw)
To: u-boot
Hello Holger,
Am 30.06.2017 um 15:33 schrieb Holger Brunck:
> The 82xx board mgcoge3ne was removed from the codebase, so this is dead
> code.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> board/keymile/common/common.c | 3 ---
> 1 file changed, 3 deletions(-)
nice catch! Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
> index 0829b7fa06..408079c9a1 100644
> --- a/board/keymile/common/common.c
> +++ b/board/keymile/common/common.c
> @@ -355,9 +355,6 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
> #if defined(CONFIG_POST)
> testpin = post_hotkeys_pressed();
> #endif
> -#if defined(CONFIG_MGCOGE3NE)
> - testpin = get_testpin();
> -#endif
> s = getenv("test_bank");
> /* when test_bank is not set, act as if testpin is not asserted */
> testboot = (testpin != 0) && (s);
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] km/common: remove unused code
2017-06-30 13:33 [U-Boot] [PATCH] km/common: remove unused code Holger Brunck
2017-06-30 13:52 ` Heiko Schocher
@ 2017-07-07 11:41 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-07-07 11:41 UTC (permalink / raw)
To: u-boot
On Fri, Jun 30, 2017 at 03:33:35PM +0200, Holger Brunck wrote:
> The 82xx board mgcoge3ne was removed from the codebase, so this is dead
> code.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Cc: Heiko Schocher <hs@denx.de>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170707/103baa90/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-07 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-30 13:33 [U-Boot] [PATCH] km/common: remove unused code Holger Brunck
2017-06-30 13:52 ` Heiko Schocher
2017-07-07 11:41 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox