public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] avr32: Retire AVR32 for good
Date: Wed, 5 Jul 2017 05:08:26 +0200	[thread overview]
Message-ID: <595C582A.8080202@denx.de> (raw)
In-Reply-To: <20170704162543.8267-1-andriy.shevchenko@linux.intel.com>

Hello Andy,

Am 04.07.2017 um 18:25 schrieb Andy Shevchenko:
> AVR32 is gone. It's already more than two years for no support in Buildroot,
> even longer there is no support in GCC (last version is heavily patched 4.2.4).
>
> Linux kernel v4.12 got rid of it (and v4.11 didn't build successfully).
>
> There is no good point to keep this support in U-Boot either.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks!

Hmm... nitpick:

> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 95f27b6ead..21616f171f 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -145,11 +145,6 @@ CONFIG_ATMEL_MCI_8BIT
>  CONFIG_ATMEL_NAND_HWECC
>  CONFIG_ATMEL_NAND_HW_PMECC
>  CONFIG_ATMEL_SPI0
> -CONFIG_ATNGW100
> -CONFIG_ATNGW100MKII
> -CONFIG_ATSTK1000
> -CONFIG_ATSTK1000_16MB_SDRAM
> -CONFIG_ATSTK1002
>  CONFIG_AT_TRANS
>  CONFIG_AUTONEG_TIMEOUT
>  CONFIG_AUTO_COMPLETE

It seems you do not remove all avr32 specific defines here from this
list, for example:

pollux:u-boot hs [master] $ grep -lr SYS_CLKDIV_CPU .
./arch/avr32/cpu/at32ap700x/clk.c
./arch/avr32/cpu/cpu.c
./arch/avr32/include/asm/arch-at32ap700x/clk.h
./scripts/config_whitelist.txt
./include/configs/atstk1002.h
./include/configs/grasshopper.h
./include/configs/atngw100.h
./include/configs/atngw100mkii.h
pollux:u-boot hs [master] $

Can you please try to check here the defines you remove for
example in arch/avr32/cpu?

Oh... you do not remove the "grasshoper" board ... it is also
an AVR32 based board:

pollux:u-boot hs [master] $ cat configs/grasshopper_defconfig | grep AVR32
CONFIG_AVR32=y
pollux:u-boot hs [master] $

pollux:u-boot hs [master] $ find ./configs/ -name '*defconfig' | xargs grep 'AVR32'
./configs/grasshopper_defconfig:CONFIG_AVR32=y
./configs/atngw100_defconfig:CONFIG_AVR32=y
./configs/atngw100mkii_defconfig:CONFIG_AVR32=y
./configs/atstk1002_defconfig:CONFIG_AVR32=y
pollux:u-boot hs [master] $

Ok, you only missed the grasshoper board, can you please remove this
too?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2017-07-05  3:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 16:25 [U-Boot] [PATCH v1] avr32: Retire AVR32 for good Andy Shevchenko
2017-07-04 19:37 ` Tom Rini
2017-07-04 19:50   ` Simon Glass
2017-07-05  3:08 ` Heiko Schocher [this message]
2017-07-05  3:21   ` Tom Rini
2017-07-05  9:49   ` Andy Shevchenko
2017-07-05 10:04     ` Heiko Schocher
2017-07-05 10:00 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595C582A.8080202@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox