[U-Boot] [PATCH v1] avr32: Retire AVR32 for good

Heiko Schocher
2017-07-05T10:04:15Z

Hello Andy,

Am 05.07.2017 um 11:49 schrieb Andy Shevchenko:
> On Wed, Jul 5, 2017 at 6:08 AM, Heiko Schocher <hs@denx.de> wrote:
>> Am 04.07.2017 um 18:25 schrieb Andy Shevchenko:
>>>
>>> AVR32 is gone. It's already more than two years for no support in
>>> Buildroot,
>>> even longer there is no support in GCC (last version is heavily patched
>>> 4.2.4).
>>>
>>> Linux kernel v4.12 got rid of it (and v4.11 didn't build successfully).
>>>
>>> There is no good point to keep this support in U-Boot either.
>
>> It seems you do not remove all avr32 specific defines here from this
>> list, for example:
>>
>> pollux:u-boot hs [master] $ grep -lr SYS_CLKDIV_CPU .
>> ./arch/avr32/cpu/at32ap700x/clk.c
>> ./arch/avr32/cpu/cpu.c
>> ./arch/avr32/include/asm/arch-at32ap700x/clk.h
>> ./scripts/config_whitelist.txt
>> ./include/configs/atstk1002.h
>> ./include/configs/grasshopper.h
>> ./include/configs/atngw100.h
>> ./include/configs/atngw100mkii.h
>> pollux:u-boot hs [master] $
>>
>> Can you please try to check here the defines you remove for
>> example in arch/avr32/cpu?
>
> Thanks, I would use advice from Tom.

Fine.

>> Oh... you do not remove the "grasshoper" board ... it is also
>> an AVR32 based board:
>>
>> pollux:u-boot hs [master] $ cat configs/grasshopper_defconfig | grep AVR32
>> CONFIG_AVR32=y
>> pollux:u-boot hs [master] $
>
>> Ok, you only missed the grasshoper board, can you please remove this
>> too?
>
>>From the above patch:
> "delete mode 100644 configs/grasshopper_defconfig"
>
> What did you miss?

Ah, it was too early in the morning ...

You only remove configs/grasshopper_defconfig, but not:

./include/configs/grasshopper.h

nor the files in

./board/in-circuit/grasshopper

and as there is only one in-circuit board, please delete the complete
./board/in-circuit directory.

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany