public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/10] powerpc, 8xx: move immap.c in arch/powerpc/cpu/mpc8xx/
Date: Thu, 6 Jul 2017 11:40:16 +0200	[thread overview]
Message-ID: <595E0580.9080101@denx.de> (raw)
In-Reply-To: <0f6b1b9c0d4d1c29559bfd579591bc77506ddc19.1499329461.git.christophe.leroy@c-s.fr>

Hello Christophe,

Am 06.07.2017 um 10:33 schrieb Christophe Leroy:
> immap.c used to be common to several CPUs. It is now
> only linked to the 8xx, so this patch moves it into
> arch/powerpc/cpu/mpc8xx/
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
>   arch/powerpc/Kconfig                     | 2 --
>   arch/powerpc/cpu/mpc8xx/Kconfig          | 9 +++++++++
>   arch/powerpc/cpu/mpc8xx/Makefile         | 1 +
>   arch/powerpc/{lib => cpu/mpc8xx}/immap.c | 3 ---
>   arch/powerpc/lib/Kconfig                 | 7 -------
>   arch/powerpc/lib/Makefile                | 1 -
>   6 files changed, 10 insertions(+), 13 deletions(-)
>   rename arch/powerpc/{lib => cpu/mpc8xx}/immap.c (99%)
>   delete mode 100644 arch/powerpc/lib/Kconfig

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index a7558d59b2..e9002a76ab 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -34,8 +34,6 @@ config 8xx
>
>   endchoice
>
> -source "arch/powerpc/lib/Kconfig"
> -
>   source "arch/powerpc/cpu/mpc83xx/Kconfig"
>   source "arch/powerpc/cpu/mpc85xx/Kconfig"
>   source "arch/powerpc/cpu/mpc86xx/Kconfig"
> diff --git a/arch/powerpc/cpu/mpc8xx/Kconfig b/arch/powerpc/cpu/mpc8xx/Kconfig
> index a425cba8aa..cb15dc5ebc 100644
> --- a/arch/powerpc/cpu/mpc8xx/Kconfig
> +++ b/arch/powerpc/cpu/mpc8xx/Kconfig
> @@ -10,4 +10,13 @@ choice
>
>   endchoice
>
> +comment "Specific commands"
> +
> +config CMD_IMMAP
> +	bool "Enable various commands to dump IMMR information"
> +	help
> +	  This enables various commands such as:
> +
> +	    siuinfo - print System Interface Unit (SIU) registers
> +	    memcinfo - print Memory Controller registers
>   endmenu
> diff --git a/arch/powerpc/cpu/mpc8xx/Makefile b/arch/powerpc/cpu/mpc8xx/Makefile
> index 5dd801d76e..eae02da636 100644
> --- a/arch/powerpc/cpu/mpc8xx/Makefile
> +++ b/arch/powerpc/cpu/mpc8xx/Makefile
> @@ -11,6 +11,7 @@ obj-y	+= cpu.o
>   obj-y	+= cpu_init.o
>   obj-y	+= fec.o
>   obj-$(CONFIG_OF_LIBFDT) += fdt.o
> +obj-$(CONFIG_CMD_IMMAP) += immap.o
>   obj-y	+= interrupts.o
>   obj-y	+= serial.o
>   obj-y	+= speed.o
> diff --git a/arch/powerpc/lib/immap.c b/arch/powerpc/cpu/mpc8xx/immap.c
> similarity index 99%
> rename from arch/powerpc/lib/immap.c
> rename to arch/powerpc/cpu/mpc8xx/immap.c
> index 1beed1fa40..5ff6aa5e3b 100644
> --- a/arch/powerpc/lib/immap.c
> +++ b/arch/powerpc/cpu/mpc8xx/immap.c
> @@ -12,8 +12,6 @@
>   #include <common.h>
>   #include <command.h>
>
> -#if defined(CONFIG_8xx)
> -
>   #include <asm/8xx_immap.h>
>   #include <commproc.h>
>   #include <asm/iopin_8xx.h>
> @@ -394,4 +392,3 @@ U_BOOT_CMD(
>   	"print Baud Rate Generator (BRG) registers",
>   	""
>   );
> -#endif
> diff --git a/arch/powerpc/lib/Kconfig b/arch/powerpc/lib/Kconfig
> deleted file mode 100644
> index 7c8ea971c3..0000000000
> --- a/arch/powerpc/lib/Kconfig
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -config CMD_IMMAP
> -	bool "Enable various commands to dump IMMR information"
> -	help
> -	  This enables various commands such as:
> -
> -	    siuinfo - print System Interface Unit (SIU) registers
> -	    memcinfo - print Memory Controller registers
> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
> index 4aa41836a2..9a3043abf8 100644
> --- a/arch/powerpc/lib/Makefile
> +++ b/arch/powerpc/lib/Makefile
> @@ -32,7 +32,6 @@ obj-$(CONFIG_BAT_RW) += bat_rw.o
>   obj-$(CONFIG_CMD_BOOTM) += bootm.o
>   obj-y	+= cache.o
>   obj-y	+= extable.o
> -obj-$(CONFIG_CMD_IMMAP) += immap.o
>   obj-y	+= interrupts.o
>   obj-$(CONFIG_CMD_KGDB) += kgdb.o
>   obj-y	+= stack.o
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2017-07-06  9:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  8:33 [U-Boot] [PATCH v2 0/10] powerpc, 8xx: Modernise the 8xx Christophe Leroy
2017-07-06  8:33 ` [U-Boot] [PATCH v2 01/10] powerpc, 8xx: move immap.c in arch/powerpc/cpu/mpc8xx/ Christophe Leroy
2017-07-06  8:41   ` Christophe LEROY
2017-07-06  9:40   ` Heiko Schocher [this message]
2017-07-09  0:24   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 02/10] powerpc, 8xx: move specific reginfo Christophe Leroy
2017-07-06  9:40   ` Heiko Schocher
2017-07-09  0:24   ` [U-Boot] [U-Boot,v2,02/10] " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 03/10] powerpc, 8xx: Use IO accessors to access IO memory Christophe Leroy
2017-07-06  9:41   ` Heiko Schocher
2017-07-09  0:24   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 04/10] powerpc, 8xx: Implement GLL2 ERRATA Christophe Leroy
2017-07-06  9:43   ` Heiko Schocher
2017-07-06 10:56   ` Wolfgang Denk
2017-07-06 11:12     ` Christophe LEROY
2017-07-06 11:18       ` Christophe LEROY
2017-07-06 11:20       ` Wolfgang Denk
2017-07-06  8:33 ` [U-Boot] [PATCH v2 05/10] powerpc, 8xx: Handle checkpatch errors and some of the warnings/checks Christophe Leroy
2017-07-06  9:43   ` Heiko Schocher
2017-07-09  0:24   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 06/10] powerpc, 8xx: Properly set CPM frequency in the device tree Christophe Leroy
2017-07-06  9:46   ` Heiko Schocher
2017-07-09  0:25   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 07/10] powerpc, 8xx: Migrate to Kconfig Christophe Leroy
2017-07-06  8:57   ` Bin Meng
2017-07-06  9:47   ` Heiko Schocher
2017-07-09  0:25   ` [U-Boot] [U-Boot,v2,07/10] " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 08/10] powerpc, 8xx: move FEC Ethernet driver in drivers/net Christophe Leroy
2017-07-06  8:54   ` Bin Meng
2017-07-06 12:02     ` Tom Rini
2017-07-09  0:25   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 09/10] powerpc, 8xx: move SPI driver to drivers/spi/ Christophe Leroy
2017-07-09  0:25   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-07-06  8:33 ` [U-Boot] [PATCH v2 10/10] powerpc, 8xx: move Serial driver to drivers/serial/ Christophe Leroy
2017-07-09  0:25   ` [U-Boot] [U-Boot, v2, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595E0580.9080101@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox