[U-Boot] [PATCH v2 04/10] powerpc, 8xx: Implement GLL2 ERRATA

Wolfgang Denk
2017-07-06T11:20:08Z

Dear Christophe,

In message <1e6c1b5c-2e49-6784-6d6d-f4532aa20434@c-s.fr> you wrote:
>
> > Like a few lines above, you could/should use a single call to
> > clrsetbits_be32() here. And as Heiko already commented, please use
> > readable names istead of the magic numbers.
>
> I shall not use clrsetbits_be32(), because the ERRATA says:
>
> Program the PLPRCR such that the PLL clock will change, then reprogram
> the PLPRCR value back to the desired value

Ah! This is critical information, so please add a comment to explain
this. [Otherwise there is the risk some later "optimization" intro-
duces a bug.]

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had been eight years upon a project for extracting sunbeams out of
cucumbers, which were to be put in vials hermetically sealed, and let
out to warm the air in raw inclement summers. - Jonathan Swift
_Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5