From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4437C63705 for ; Wed, 7 Dec 2022 20:09:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E1A783A08; Wed, 7 Dec 2022 21:08:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="eQgeZ9fn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 209B884480; Wed, 7 Dec 2022 21:08:55 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25EFF83A08 for ; Wed, 7 Dec 2022 21:08:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=detlev.casanova@collabora.com Received: from falcon9.localnet (bras-base-mtrlpq02hsy-grc-05-174-93-253-174.dsl.bell.ca [174.93.253.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0F7EB6602BC8; Wed, 7 Dec 2022 20:08:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1670443729; bh=5gmyyhGa+j3oMq756Sc9OGwrKXgRgpHGtV8GDOc3Lok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eQgeZ9fnvbcfnB8eQ72Wz9Ye/xD28piYixz2joOoMB+XyrvYWneC/9+14dROJqikP k7jVQIUJWW878vBfh+qCJ1vDVDqN6aAcKMGsy+qa1wB5uggvNwUUyWMMXE8xB3CDc4 PzTeJD3XSkLxs+2IS2BJpTQe4qZJviY/meZFY+hJcUNbDm0EfC6kiGYgQ89NFCSQ1O F9xbt+LU7tFOwHRGN3J3Mj6yvGks6z5o6tEkowh2DRutpHb5CjM7k/HhRlUpaiX2AT GP4z0WHU1Pku592TBbHQ5hwT6xV0ayYzkjBZ7UAFwwn0o6w+fWforiLRU98MFtrK8a h6mbjuw2k9R4w== From: Detlev Casanova To: Fabio Estevam , Tom Rini Cc: Troy Kisky , u-boot@lists.denx.de, Stefano Babic , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Date: Wed, 07 Dec 2022 15:08:46 -0500 Message-ID: <5971609.lOV4Wx5bFT@falcon9> In-Reply-To: <20221207200356.GX3787616@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <20221207200356.GX3787616@bill-the-cat> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wednesday, December 7, 2022 3:03:56 P.M. EST Tom Rini wrote: > On Mon, Dec 05, 2022 at 02:33:48PM -0300, Fabio Estevam wrote: > > On Mon, Dec 5, 2022 at 12:37 PM Tom Rini wrote: > > > I'm not really happy with this approach. It's not that upstream doesn't > > > have aliases now, it's that it has different aliases, right? That's why > > > they won't accept these? > > > > imx6q.dtsi does have the default mmc aliases: > > > > mmc0 = &usdhc1; > > mmc1 = &usdhc2; > > mmc2 = &usdhc3; > > mmc3 = &usdhc4; > > > > Upstream does not want to change mmc alias because users may rely on > > this mmc aliases. > > > > Changing it now may cause the board not to boot anymore as the rootfs > > cannot be found. > > > > It is OK to change mmc alias for a newly introduced board, but please > > keep in mind that > > wandboard and sabrelite have been launched many many years ago. > > > > So for upstream Linux the message was clear: don't change the mmc > > alias for these boards. > > > > Now let's talk about U-Boot. > > > > Prior to d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with > > > > linux") the mmc alias for sabrelite was present: > > mmc0 = &usdhc3; > > mmc1 = &usdhc4; > > > > After this commit, the mmc alias is gone and causes the boot > > regression as reported by Detlev. > > > > We don't want to cause regressions in U-Boot as well, so that's why I > > propose just adding the alias into u-boot.dtsi. > > > > There are many boards that does the same. > > > > > But this also highlights that we really need to get these kind of > > > aliases and similar (a) re-synced with upstream ASAP and (b) do that at > > > > imx6 dts files are already synced with Linux. > > > > > the start. I don't know which group of "users are broken by this change" > > > is bigger, the group that needs the aliases we have or the group that > > > needs the other aliases, but the group that gets changes upstream first > > > "wins" here is how the OSS world works. > > > > I prefer to not break things for anyone, hence my proposal. > > > > If you are still not happy with it, please feel free to submit a patch > > with your proposal. > > I don't know what we can do about the existing boards, but we need to > NOT do this moving forward. We need to use whatever the aliases are > upstream already, or upstream the aliases we want to use. Yes, I agree that aliases should be kept in sync with the kernel. But this case is particular because this board has been using different aliases in u- boot and in linux for some time (maybe since forever). So this should be kept to avoid breaking existing u-boot setups when they are upgraded.