From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/3] Armada100: Enable Ethernet support for GplugD
Date: Fri, 2 Sep 2011 11:25:43 +0530 (IST) [thread overview]
Message-ID: <598579349.20494.1314942943430.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <201109020758.21326.marek.vasut@gmail.com>
----- "Marek Vasut" <marek.vasut@gmail.com> wrote:
> On Friday, September 02, 2011 07:18:40 AM Ajay Bhargav wrote:
> > This patch enables ethernet support for Marvell GplugD board.
> Network
> > related commands works.
> >
> > Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> > ---
> > Changes for v2:
> > - armada100_fec_initialize changed to armada100_fec_register
> > Changes for v3:
> > - fec base address as argument to armada100_fec_register
> > Changes for v4:
> > - Not changed
> > Changes for v5:
> > - Coding style cleanup
> >
[...]
> > +/* DHCP Support */
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_BOOTP_DHCP_REQUEST_DELAY 50000
> > +#define CONFIG_BOOTP_SERVERIP
>
> Why is this empty?
>
oops!? missed? :/ Prafulla, can You remove this?
> #define CONFIG_BOOTP_SERVERIP
or should I email again? I donno how I missed this.
> Other than that,
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> > +
> > +/* Default Boot Parameters */
> > +#define CONFIG_ROOTPATH "/tftpboot"
> > +#define CONFIG_SYS_IMG_NAME "uImage"
> >
> > /*
> > * mv-common.h should be defined after CMD configs since it used
> them
>
Thanks,
Ajay Bhargav
next prev parent reply other threads:[~2011-09-02 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 5:18 [U-Boot] [PATCH v5 2/3] Armada100: Enable Ethernet support for GplugD Ajay Bhargav
2011-09-02 5:58 ` Marek Vasut
2011-09-02 5:55 ` Ajay Bhargav [this message]
2011-09-07 21:35 ` Wolfgang Denk
2011-09-08 4:39 ` Ajay Bhargav
2011-09-08 6:42 ` Prafulla Wadaskar
2011-09-08 6:34 ` Ajay Bhargav
2011-09-08 6:31 ` Prafulla Wadaskar
2011-09-08 6:27 ` Ajay Bhargav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=598579349.20494.1314942943430.JavaMail.root@ahm.einfochips.com \
--to=ajay.bhargav@einfochips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox