public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] odroid-c2: enable I2C
Date: Sun, 29 Oct 2017 15:42:30 +0100	[thread overview]
Message-ID: <59F5E8D6.50803@baylibre.com> (raw)
In-Reply-To: <20171029090901.24299-3-b.galvani@gmail.com>



Le 29/10/2017 10:09, Beniamino Galvani a écrit :
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>  arch/arm/include/asm/arch-meson/gxbb.h | 1 +
>  board/amlogic/odroid-c2/odroid-c2.c    | 1 +
>  configs/odroid-c2_defconfig            | 3 +++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-meson/gxbb.h b/arch/arm/include/asm/arch-meson/gxbb.h
> index ce41349792..96c9535f53 100644
> --- a/arch/arm/include/asm/arch-meson/gxbb.h
> +++ b/arch/arm/include/asm/arch-meson/gxbb.h
> @@ -44,6 +44,7 @@
>  #define GXBB_GCLK_MPEG_OTHER	GXBB_HIU_ADDR(0x53)
>  #define GXBB_GCLK_MPEG_AO	GXBB_HIU_ADDR(0x54)
>  
> +#define GXBB_GCLK_MPEG_0_I2C   BIT(9)
>  #define GXBB_GCLK_MPEG_1_ETH	BIT(3)
>  
>  #endif /* __GXBB_H__ */
> diff --git a/board/amlogic/odroid-c2/odroid-c2.c b/board/amlogic/odroid-c2/odroid-c2.c
> index eac04d8178..a5ea8dc5af 100644
> --- a/board/amlogic/odroid-c2/odroid-c2.c
> +++ b/board/amlogic/odroid-c2/odroid-c2.c
> @@ -35,6 +35,7 @@ int misc_init_r(void)
>  				     GXBB_ETH_REG_0_CLK_EN);
>  
>  	/* Enable power and clock gate */
> +	setbits_le32(GXBB_GCLK_MPEG_0, GXBB_GCLK_MPEG_0_I2C);

Hi Beniamino,

At some point, this should maybe be implemented as a (basic) clock driver to handle these gates.

Neil

>  	setbits_le32(GXBB_GCLK_MPEG_1, GXBB_GCLK_MPEG_1_ETH);
>  	clrbits_le32(GXBB_MEM_PD_REG_0, GXBB_MEM_PD_REG_0_ETH_MASK);
>  
> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
> index f7f8016644..1afd2fc111 100644
> --- a/configs/odroid-c2_defconfig
> +++ b/configs/odroid-c2_defconfig
> @@ -11,12 +11,15 @@ CONFIG_DEBUG_UART=y
>  # CONFIG_CMD_IMI is not set
>  # CONFIG_CMD_FPGA is not set
>  CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
>  # CONFIG_CMD_LOADS is not set
>  CONFIG_CMD_MMC=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_OF_CONTROL=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_DM_GPIO=y
> +CONFIG_DM_I2C=y
> +CONFIG_SYS_I2C_MESON=y
>  CONFIG_DM_MMC=y
>  CONFIG_MMC_MESON_GX=y
>  CONFIG_DM_ETH=y
> 

  reply	other threads:[~2017-10-29 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29  9:08 [U-Boot] [PATCH 0/2] Amlogic I2C driver for u-boot Beniamino Galvani
2017-10-29  9:09 ` [U-Boot] [PATCH 1/2] i2c: add Amlogic Meson driver Beniamino Galvani
2017-10-29 14:44   ` Neil Armstrong
2017-11-20 12:39   ` Heiko Schocher
2017-11-20 15:36   ` Simon Glass
2017-11-26 16:49     ` Beniamino Galvani
2017-11-27 17:10       ` Simon Glass
2017-10-29  9:09 ` [U-Boot] [PATCH 2/2] odroid-c2: enable I2C Beniamino Galvani
2017-10-29 14:42   ` Neil Armstrong [this message]
2017-11-20 12:40   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F5E8D6.50803@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox