public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support
Date: Sun, 29 Oct 2017 15:47:53 +0100	[thread overview]
Message-ID: <59F5EA19.1090608@baylibre.com> (raw)
In-Reply-To: <20171029120411.GV12185@bill-the-cat>



Le 29/10/2017 13:04, Tom Rini a écrit :
> On Thu, Oct 26, 2017 at 03:39:17PM +0200, Neil Armstrong wrote:
>> On 22/10/2017 16:36, Simon Glass wrote:
>>> On 18 October 2017 at 10:02, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.
>>>>
>>>> The PHY acts as a generic PHY but needs a slight configuration right
>>>> before it's configuration.
>>>>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>>  drivers/net/phy/Kconfig     |  3 +++
>>>>  drivers/net/phy/Makefile    |  1 +
>>>>  drivers/net/phy/meson-gxl.c | 57 +++++++++++++++++++++++++++++++++++++++++++++
>>>>  drivers/net/phy/phy.c       |  3 +++
>>>>  include/phy.h               |  1 +
>>>>  5 files changed, 65 insertions(+)
>>>>  create mode 100644 drivers/net/phy/meson-gxl.c
>>>
>>> We really should create a uclass for PHY drivers before adding any
>>> more of these.
>>>
>>> Regards,
>>> Simon
>>>
>>
>> Hi Simon,
>>
>> Sure, this would indeed be necessary, but is it necessary to wait for
>> the uclass to merge mode PHYs ?
> 
> Well, this isn't going in before the next release (along with all of the
> other amlogic stuff, which looks good otherwise btw).  So, do you have
> time to take a pass at a uclass?
> 

Hi Tom, Simon,

I can give a try, but with my limited uclass/dm knowledge, it will only be basic and will some review.

Should the plan be to introduce DM support for net PHY subsystem, then introduce this meson GXL phy as first implementation ?

Should I remove support for non-dm PHY drivers and probing when DM is enabled ?

Neil

  reply	other threads:[~2017-10-29 14:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18  8:02 [U-Boot] [PATCH u-boot 0/3] Add Ethernet support for Amlogic P212 Reference board Neil Armstrong
2017-10-18  8:02 ` [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support Neil Armstrong
2017-10-22 14:36   ` Simon Glass
2017-10-26 13:39     ` Neil Armstrong
2017-10-29 12:04       ` Tom Rini
2017-10-29 14:47         ` Neil Armstrong [this message]
2017-11-17 15:43   ` [U-Boot] [U-Boot, u-boot, " Tom Rini
2017-10-18  8:02 ` [U-Boot] [PATCH u-boot 2/3] arm: meson: Add supplementary ethernet registers definitions Neil Armstrong
2017-11-17 15:43   ` [U-Boot] [U-Boot, u-boot, " Tom Rini
2017-10-18  8:02 ` [U-Boot] [PATCH u-boot 3/3] arm: amlogic: p212: Add support for Ethernet with Internal PHY Neil Armstrong
2017-11-17 15:43   ` [U-Boot] [U-Boot, u-boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F5EA19.1090608@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox