From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Date: Sun, 29 Oct 2017 15:47:53 +0100 Subject: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support In-Reply-To: <20171029120411.GV12185@bill-the-cat> References: <1508313732-19282-1-git-send-email-narmstrong@baylibre.com> <1508313732-19282-2-git-send-email-narmstrong@baylibre.com> <0921db70-a4bb-ea2e-d273-44280a2acc3c@baylibre.com> <20171029120411.GV12185@bill-the-cat> Message-ID: <59F5EA19.1090608@baylibre.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Le 29/10/2017 13:04, Tom Rini a =C3=A9crit : > On Thu, Oct 26, 2017 at 03:39:17PM +0200, Neil Armstrong wrote: >> On 22/10/2017 16:36, Simon Glass wrote: >>> On 18 October 2017 at 10:02, Neil Armstrong w= rote: >>>> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PH= Y. >>>> >>>> The PHY acts as a generic PHY but needs a slight configuration right >>>> before it's configuration. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> drivers/net/phy/Kconfig | 3 +++ >>>> drivers/net/phy/Makefile | 1 + >>>> drivers/net/phy/meson-gxl.c | 57 ++++++++++++++++++++++++++++++++++++= +++++++++ >>>> drivers/net/phy/phy.c | 3 +++ >>>> include/phy.h | 1 + >>>> 5 files changed, 65 insertions(+) >>>> create mode 100644 drivers/net/phy/meson-gxl.c >>> >>> We really should create a uclass for PHY drivers before adding any >>> more of these. >>> >>> Regards, >>> Simon >>> >> >> Hi Simon, >> >> Sure, this would indeed be necessary, but is it necessary to wait for >> the uclass to merge mode PHYs ? >=20 > Well, this isn't going in before the next release (along with all of the > other amlogic stuff, which looks good otherwise btw). So, do you have > time to take a pass at a uclass? >=20 Hi Tom, Simon, I can give a try, but with my limited uclass/dm knowledge, it will only be = basic and will some review. Should the plan be to introduce DM support for net PHY subsystem, then intr= oduce this meson GXL phy as first implementation ? Should I remove support for non-dm PHY drivers and probing when DM is enabl= ed ? Neil