From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Lilja Date: Tue, 10 Jun 2008 14:34:14 +0200 Subject: [U-Boot-Users] [Junk released by Allow List] Command history no longer working In-Reply-To: <1212091109.2236.3.camel@localhost.localdomain> References: <42848A5C5A0D1E47B026E644DD49B08E02725D71@mail> <42848A5C5A0D1E47B026E644DD49B08E02725DB2@mail> <1212091109.2236.3.camel@localhost.localdomain> Message-ID: <59b21cf20806100534w7bdc4e0bv9d06aeccf482098a@mail.gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi On Thu, May 29, 2008 at 9:58 PM, Kenneth Johansson wrote: >> I noticed that not a lot of platforms/boards set GD_FLG_RELOC so >> command history will probably cease to work for these boards also? > > Most boards do the relocation and then it gets set by the common > board_init_r() function. I got hit by this problem today and only after I figured out what was really wrong I searched the mailing list archives and found this thread (and a couple of others). I'm using an ARM board and as far as I can see lib_arm/board.c does not set the GD_FLG_RELOC bit, in fact no ARM boards do so in the current git tree (according to grep anyway). Many other architectures set the flag in their respective common lib_/board.c. Should/can the GD_FLG_RELOC be set in a common place (lib_arm/board.c:start_armboot) for ARM as well? Or shall we place gd->flags |= GD_FLG_RELOC in the board specific init routines/files? Regards, Magnus Lilja