From: Seung-Woo Kim <sw0312.kim@samsung.com>
To: u-boot@lists.denx.de
Subject: [PATCH] mmc: bcm283x: fix int to pointer cast
Date: Sat, 16 May 2020 11:57:17 +0900 [thread overview]
Message-ID: <5EBF568D.9050103@samsung.com> (raw)
In-Reply-To: <fe4e6207-f09a-448e-ae2f-9b1d7adf5185@samsung.com>
Hi Jaehoon,
On 2020? 05? 15? 20:07, Jaehoon Chung wrote:
> On 5/15/20 7:14 PM, Seung-Woo Kim wrote:
>> On build with 32 bit, there is a warning for int-to-pointer-cast.
>> Fix the int to pointer cast by using uintptr_t.
>
> Could you share in more detail? I didn't see any warning with gcc 9.2 / 8.3 / 7.4 /6.5.
Sorry for not giving detail. If I applied PICe XHCI support [1], and
build rpi_4_32b, then I got related warning.
If [1] is not applied, then this can be ignored.
[1]
https://patchwork.ozlabs.org/project/uboot/patch/20200504124523.23484-7-s.nawrocki at samsung.com/
Best Regards,
- Seung-Woo Kim
>
>
> Best Regards,
> Jaehoon Chung
>
>
>>
>> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
>> ---
>> drivers/mmc/bcm2835_sdhci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/bcm2835_sdhci.c b/drivers/mmc/bcm2835_sdhci.c
>> index 39c93db275..c31f099f25 100644
>> --- a/drivers/mmc/bcm2835_sdhci.c
>> +++ b/drivers/mmc/bcm2835_sdhci.c
>> @@ -209,7 +209,7 @@ static int bcm2835_sdhci_probe(struct udevice *dev)
>> priv->last_write = 0;
>>
>> host->name = dev->name;
>> - host->ioaddr = (void *)base;
>> + host->ioaddr = (void *)(uintptr_t)base;
>> host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B |
>> SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_NO_HISPD_BIT;
>> host->max_clk = emmc_freq;
>>
>
>
>
--
Seung-Woo Kim
Samsung Research
--
next prev parent reply other threads:[~2020-05-16 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200515101400epcas1p25d3d3ba611bde5628cba9cade6682c8f@epcas1p2.samsung.com>
2020-05-15 10:14 ` [PATCH] mmc: bcm283x: fix int to pointer cast Seung-Woo Kim
2020-05-15 11:07 ` Jaehoon Chung
2020-05-16 2:57 ` Seung-Woo Kim [this message]
2020-05-18 7:24 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EBF568D.9050103@samsung.com \
--to=sw0312.kim@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox