public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: Nikhil M Jain <n-jain1@ti.com>, <u-boot@lists.denx.de>,
	<sjg@chromium.org>
Cc: <trini@konsulko.com>, <vigneshr@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH V5 03/13] drivers: Makefile: Add rule to compile video driver
Date: Mon, 3 Apr 2023 16:18:41 +0530	[thread overview]
Message-ID: <5a279236-2fb1-e953-5687-3b1ec0b95d21@ti.com> (raw)
In-Reply-To: <20230403081443.77933-4-n-jain1@ti.com>

Hi Nikhil,

On 03/04/23 13:44, Nikhil M Jain wrote:
> CONFIG_$(SPL_)VIDEO checks for CONFIG_SPL_VIDEO at SPL and CONFIG_VIDEO
> at u-boot proper and compiles video driver at respective stage.
> 

Please update above commit message per the new patch change as
CONFIG_$(SPL_)VIDEO is not used now. After above change, kindly add,

> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh
> ---
> V5:
> - Add rule to build video at SPL using CONFIG_SPL_VIDEO and retain
>   obj-y +=video for u-boot proper.
> 
> V4:
> - No change
> 
> V3 (patch introduced):
> - Add rule to compile video driver at SPL.
> 
>  drivers/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 58be410135..928a8b0e9d 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -61,6 +61,7 @@ obj-$(CONFIG_SPL_USB_HOST) += usb/host/
>  obj-$(CONFIG_SPL_SATA) += ata/ scsi/
>  obj-$(CONFIG_SPL_LEGACY_BLOCK) += block/
>  obj-$(CONFIG_SPL_THERMAL) += thermal/
> +obj-$(CONFIG_SPL_VIDEO) +=video/
>  
>  endif
>  endif

  reply	other threads:[~2023-04-03 10:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03  8:14 [PATCH V5 00/13] Add splash screen support at u-boot SPL Nikhil M Jain
2023-04-03  8:14 ` [PATCH V5 01/13] drivers: video: Kconfig: Add configs for enabling video at SPL Nikhil M Jain
2023-04-03  8:14 ` [PATCH V5 02/13] drivers: video: tidss: Kconfig: Configs to enable TIDSS " Nikhil M Jain
2023-04-03 10:47   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 03/13] drivers: Makefile: Add rule to compile video driver Nikhil M Jain
2023-04-03 10:48   ` Devarsh Thakkar [this message]
2023-04-03  8:14 ` [PATCH V5 04/13] drivers: video: Makefile: Rule to compile necessary video driver files Nikhil M Jain
2023-04-03 10:51   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 05/13] drivers: video: tidss: Makefile: Add condition to compile TIDSS at SPL Nikhil M Jain
2023-04-03  8:14 ` [PATCH V5 06/13] common: Makefile: Add rule to compile splash and splash_source " Nikhil M Jain
2023-04-03 10:57   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 07/13] common: Kconfig: Add BMP configs Nikhil M Jain
2023-04-03 11:00   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 08/13] cmd: bmp: Split bmp commands and functions Nikhil M Jain
2023-04-03 11:30   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 09/13] common: Makefile: Rule to compile bmp.c Nikhil M Jain
2023-04-03 11:30   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 10/13] drivers: video: Enable necessary video functions at SPL Nikhil M Jain
2023-04-03  8:14 ` [PATCH V5 11/13] common: Enable splash " Nikhil M Jain
2023-04-03 11:35   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 12/13] include: Enable video related global data variable and splash " Nikhil M Jain
2023-04-03 11:41   ` Devarsh Thakkar
2023-04-03  8:14 ` [PATCH V5 13/13] board: ti: am62x: evm: OSPI support for splash screen Nikhil M Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a279236-2fb1-e953-5687-3b1ec0b95d21@ti.com \
    --to=devarsht@ti.com \
    --cc=n-jain1@ti.com \
    --cc=nsekhar@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox