public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Marek Vasut <marex@nabladev.com>,
	Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
	Tien Fong Chee <tien.fong.chee@altera.com>,
	Simon Glass <sjg@chromium.org>, Sune Brian <briansune@gmail.com>
Subject: Re: [PATCH v2 4/5] arch: arm: mach-socfpga: Adjust a raw sectors for MMC loading of U-Boot from SPL
Date: Thu, 11 Dec 2025 17:17:35 +0100	[thread overview]
Message-ID: <5a8e34ef-9643-4a88-b40b-e8e57cd7a607@siemens.com> (raw)
In-Reply-To: <CANp-EDbL8M=PqT0X_vvHSYmi_9ErR_1oeLO_qs9-3JinA-eiFg@mail.gmail.com>

On 03.12.25 21:32, Ralph Siemsen wrote:
> Hi Jan,
> 
> On Mon, Dec 1, 2025 at 2:33 AM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach-socfpga/board.c
>> index 28554b7a109..0b04f2bcacf 100644
>> --- a/arch/arm/mach-socfpga/board.c
>> +++ b/arch/arm/mach-socfpga/board.c
>> @@ -209,3 +210,13 @@ void lmb_arch_add_memory(void)
>>         }
>>  }
>>  #endif
>> +
>> +#if (defined(TARGET_SOCFPGA_ARRIA10) || defined(TARGET_SOCFPGA_GEN5)) && \
>> +    defined(CONFIG_XPL_BUILD)
> 
> This seems to be missing two CONFIG_ prefixes:
> 
> #if (defined(CONFIG_TARGET_SOCFPGA_ARRIA10) ||
> defined(CONFIG_TARGET_SOCFPGA_GEN5)) &&
> 

Indeed. I was lacking a target to catch this. v3 is on the way.

Thanks,
Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

  reply	other threads:[~2025-12-11 16:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01  7:32 [PATCH v2 0/5] Fixes for CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION* and for SOCFPGA Jan Kiszka
2025-12-01  7:32 ` [PATCH v2 1/5] spl: Kconfig: Add missing SPL_LOAD_BLOCK for SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE Jan Kiszka
2025-12-01 17:49   ` Tom Rini
2025-12-01  7:32 ` [PATCH v2 2/5] spl: mmc: Account for SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE being a choice Jan Kiszka
2025-12-01 17:55   ` Tom Rini
2025-12-01 19:59     ` Jan Kiszka
2025-12-01 20:01       ` Tom Rini
2025-12-01  7:32 ` [PATCH v2 3/5] spl: mmc: Respect sector value passed to mmc_load_image_raw_partition Jan Kiszka
2025-12-01 17:55   ` Tom Rini
2025-12-03 19:42   ` Ralph Siemsen
2025-12-03 20:32     ` Ralph Siemsen
2025-12-01  7:32 ` [PATCH v2 4/5] arch: arm: mach-socfpga: Adjust a raw sectors for MMC loading of U-Boot from SPL Jan Kiszka
2025-12-03 20:32   ` Ralph Siemsen
2025-12-11 16:17     ` Jan Kiszka [this message]
2025-12-01  7:32 ` [PATCH v2 5/5] configs: socfpga: Fix de0_nano_soc boot Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a8e34ef-9643-4a88-b40b-e8e57cd7a607@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=briansune@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=marex@nabladev.com \
    --cc=peng.fan@nxp.com \
    --cc=ralph.siemsen@linaro.org \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=sjg@chromium.org \
    --cc=tien.fong.chee@altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox