From: Alex G. <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/6] spl: LOAD_FIT_FULL: Do not hard-code os to IH_OS_U_BOOT
Date: Tue, 30 Mar 2021 12:54:21 -0500 [thread overview]
Message-ID: <5ca520c8-5919-57db-e7a5-884f53b738ed@gmail.com> (raw)
In-Reply-To: <CAPnjgZ39Ob12wmB-=ZqrcaX2pcDzfQvK5GLRyeAORwmS3HpUxw@mail.gmail.com>
On 3/29/21 2:43 AM, Simon Glass wrote:
> On Fri, 12 Mar 2021 at 10:32, Alexandru Gagniuc <mr.nuke.me@gmail.com> wrote:
>>
>> The information on the OS should be contained in the FIT, as the
>> self-explanatory "os" property of a node under /images. Hard-coding
>> this to U_BOOT might send us down the wrong path later in the boot
>> process.
>>
>> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
>> ---
>> common/spl/spl.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>> index 986cfbc6fd..8f6c8dba6f 100644
>> --- a/common/spl/spl.c
>> +++ b/common/spl/spl.c
>> @@ -220,8 +220,9 @@ static int spl_load_fit_image(struct spl_image_info *spl_image,
>> spl_image->size = fw_len;
>> spl_image->entry_point = fw_data;
>> spl_image->load_addr = fw_data;
>> - spl_image->os = IH_OS_U_BOOT;
>
+8 bytes. Down in the noise
Alex
>> - spl_image->name = "U-Boot";
>> + if (!fit_image_get_os(header, ret, &spl_image->os))
>> + spl_image->os = IH_OS_INVALID;
>> + spl_image->name = genimg_get_os_name(spl_image->os);
>>
>> debug(SPL_TPL_PROMPT "payload image: %32s load addr: 0x%lx size: %d\n",
>> spl_image->name, spl_image->load_addr, spl_image->size);
>> --
>> 2.26.2
>>
>
> Regards,
> Simon
>
next prev parent reply other threads:[~2021-03-30 17:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 21:32 [PATCH 0/6] SPL: FIT: Fix some omissions of SPL_LOAD_FIT_FULL and bootm Alexandru Gagniuc
2021-03-11 21:32 ` [PATCH 1/6] spl: LOAD_FIT_FULL: Fix selection of the "fdt" node Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
2021-03-11 21:32 ` [PATCH 2/6] spl: LOAD_FIT_FULL: Do not hard-code os to IH_OS_U_BOOT Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
2021-03-30 17:54 ` Alex G. [this message]
2021-04-14 19:38 ` Simon Glass
2021-03-11 21:32 ` [PATCH 3/6] spl: LOAD_FIT_FULL: Relocate FDT for u-boot payloads Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
2021-03-29 17:36 ` Alex G.
2021-03-11 21:32 ` [PATCH 4/6] spl: LOAD_FIT_FULL: Support 'kernel' and 'firmware' properties Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
2021-03-29 17:49 ` Alex G.
2021-03-11 21:32 ` [PATCH 5/6] image-fit: Accept IH_TYPE_FIRMWARE in fit_image_load() as valid Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
2021-03-11 21:32 ` [PATCH 6/6] image-fit: Accept OP-TEE images when booting a FIT Alexandru Gagniuc
2021-03-29 7:43 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ca520c8-5919-57db-e7a5-884f53b738ed@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox