From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C17BC43334 for ; Sun, 10 Jul 2022 08:42:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1C9584335; Sun, 10 Jul 2022 10:42:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 7B98384335; Sun, 10 Jul 2022 10:42:24 +0200 (CEST) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 023EE842FA for ; Sun, 10 Jul 2022 10:42:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=weijie.gao@mediatek.com X-UUID: 1924c02f20f8449ab99f36333cb964eb-20220710 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8, REQID:7e48b3df-d0d8-48b5-991c-2ae028e60279, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.8, REQID:7e48b3df-d0d8-48b5-991c-2ae028e60279, OB:0, LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:0f94e32, CLOUDID:2fadde63-0b3f-4b2c-b3a6-ed5c044366a0, C OID:a4863aaa475d,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 1924c02f20f8449ab99f36333cb964eb-20220710 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1258897189; Sun, 10 Jul 2022 16:42:08 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sun, 10 Jul 2022 16:42:07 +0800 Received: from mcddlt001.gcn.mediatek.inc (10.19.240.15) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 10 Jul 2022 16:42:07 +0800 Message-ID: <5dd08409c28aec4e61cfe35b63c0dd594920aff6.camel@mediatek.com> Subject: Re: [PULL] u-boot-mips for u-boot/next (v2022.10) From: Weijie Gao To: Daniel Schwierzeck , Tom Rini CC: Date: Sun, 10 Jul 2022 16:42:06 +0800 In-Reply-To: References: <20220708152148.21816-1-daniel.schwierzeck@gmail.com> <20220708165046.GN1146598@bill-the-cat> <236ddd8a-3c7f-96fa-7949-b23e114dc8a6@gmail.com> <20220709124302.GH1146598@bill-the-cat> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Daniel, On Sat, 2022-07-09 at 18:22 +0200, Daniel Schwierzeck wrote: > > On 09.07.22 14:43, Tom Rini wrote: > > On Sat, Jul 09, 2022 at 02:01:01PM +0200, Daniel Schwierzeck wrote: > > > Hi Tom, > > > > > > On 08.07.22 18:50, Tom Rini wrote: > > > > On Fri, Jul 08, 2022 at 05:21:48PM +0200, Daniel SchwierzeckHi > > > > Tom, wrote: > > > > > > > > > > Gitlab CI: > > > > > https://source.denx.de/u-boot/custodians/u-boot-mips/-/pi > > > > > pelines/12656 > > > > > > > > > > Azure: > > > > > https://dev.azure.com/danielschwierzeck/u-boot/_build/res > > > > > ults?buildId=30&view=results > > > > > > > > > > > > > > > The following changes since commit > > > > > 2d2c61ff0460740d9ec5a44dbef9255a8c690696: > > > > > > > > > > Merge tag 'efi-2022-07-rc7' of https://source.denx.de/u-b > > > > > oot/custodians/u-boot-efi (2022-07-06 09:17:08 -0400) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-mips.git/ > > > > > tags/mips-pull-2022-07-08 > > > > > > > > > > for you to fetch changes up to > > > > > e5fc4022af3cfd59e3459276305671a595ac5ff0: > > > > > > > > > > MAINTAINERS: update maintainer for MediaTek MIPS platform > > > > > (2022-07-08 15:13:29 +0200) > > > > > > > > > > ----------------------------------------------------------- > > > > > ----- > > > > > - MIPS: add drivers and board support for Mediatek MT7621 SoC > > > > > > > > OK, we need a few changes here, sorry. There's now migrated > > > > CONFIG > > > > symbols, most of which are easy to do and I was about to, and > > > > then I saw > > > > this: > > > > #ifdef CONFIG_TPL_BUILD > > > > #define CONFIG_SPL_START_S_PATH "arch/mips/mach- > > > > mtmips/mt7621/tpl" > > > > /* .bss will not be used by TPL */ > > > > #define CONFIG_SPL_BSS_START_ADDR 0x80000000 > > > > #define CONFIG_SPL_BSS_MAX_SIZE 0 > > > > #else > > > > #define CONFIG_SPL_START_S_PATH "arch/mips/mach- > > > > mtmips/mt7621/spl" > > > > #define CONFIG_SPL_BSS_START_ADDR 0x80140000 > > > > #define CONFIG_SPL_BSS_MAX_SIZE 0x80000 > > > > #define CONFIG_SPL_MAX_SIZE 0x30000 > > > > #endif > > > > > > > > No, you cannot abuse CONFIG_TPL_BUILD to set > > > > CONFIG_SPL_foo. Those need > > > > to become CONFIG_TPL_foo, and set appropriately. And then for > > > > [ST]PL_START_S_PATH, you need to set head-$(CONFIG_ARCH_xxx) to > > > > the > > > > right file, for SPL/TPL instead. > > > > > > > > > > do you already have patches for converting stuff like > > > CONFIG_SPL_BSS_START_ADDR prepared? Than I would wait with the > > > pull request > > > until those patches are applied to mainline and I would adapt the > > > MT7621 > > > patches. > > > > > > I could also assist with converting CONFIG_SPL_START_S_PATH > > > because that's > > > only used on MIPS and one ARM board. > > > > See what's in -next already? SPL_BSS_START_ADDR is migrated, but > > there > > were no TPL_BSS_START_ADDR cases. For START_S_PATH, the platform > > just > > needs to be reworked as I suggested above I believe, to achieve the > > desired result. > > > > sorry, didn't check the latest updates in -next and the series was > too > long on the list ;) > > TPL_BSS_START_ADDR shouldn't be necessary because MT7621 doesn't use > BSS > in TPL, the defined values where just dummy values. > > I rechecked and removed all migrated Kconfig options from mt7621.h > and > pushed an update to u-boot-mips/next. Weijie could you verify that? > If > all is okay, I'll prepare a new pull request, otherwise please send > me a > v7 patch series. > I've test the latest fixups on u-boot-mips/next, and all is ok. thx. Best Regards, Weijie