From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Eibach Date: Mon, 06 May 2013 17:02:12 +0200 Subject: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code In-Reply-To: <20130506145722.GC6931@bill-the-cat> References: <1367847325-21463-1-git-send-email-dirk.eibach@gdsys.cc> <1367847325-21463-5-git-send-email-dirk.eibach@gdsys.cc> <20130506140715.70513380E1C@gemini.denx.de> <20130506145722.GC6931@bill-the-cat> Message-ID: <5dd7594cf67775d4f9cd61abd6c364fb@gdsys.cc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, > On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote: >> Dear dirk.eibach at gdsys.cc, >> >> In message <1367847325-21463-5-git-send-email-dirk.eibach@gdsys.cc> >> you wrote: >>> >> ... >>> + fpga_set_reg(k, REG(reflection_low), >>> + REFLECTION_TESTPATTERN); >> >> This breaks bisecting. You reference functions which you only add in >> a later patch. > > Note that 'git rebase -i' and the exec keyword can help you test > bisectability. I know 'git rebase -i', but what is the exec keyword? It seems there is some room for improvement on patman :) Cheers Dirk