From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A8EC433FE for ; Thu, 6 Oct 2022 14:45:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5F1784DB2; Thu, 6 Oct 2022 16:44:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="gn6Igjxc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BDB8084DB6; Thu, 6 Oct 2022 16:44:57 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2076.outbound.protection.outlook.com [40.107.102.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9337884D99 for ; Thu, 6 Oct 2022 16:44:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GlM8OEkIH9pVRoD+qJnJHq7SxgiMvady+f7cRAx4SHvfMd/NXVHQ+mWOBc4ZoVSVudeGV4MJg7md7g0QJQKBCpN+0MHpVzxUctNIIDeAkuinKhlJZbZs36XJRSGN2vyEfZdp/Rbxh4zNHsyG0j0SQz78TmZ5xq32reM8TTs5kVzBC3sKouVThicV/yTj7Q7rmHow8ZF6uvalYnay3ureDCRhbt0WwrILv2A6JVbK1vkMS7u9NR9wE9HTTTOm2RydKKrs8JHI0l3uWJDIG4LNVp0jvaSQVuyeU8PyM36HMvDbuwB8+tMEUpb0UVTzkAGDZ9D9Got16lzhtJWU3x6B1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvaX2394ffbKw2rH+V2p2gN+nF/9eTj95gVaZ1EOwus=; b=gxUHN0jo22KBbylgst2reFcyjHHueKX7TJ6+cyheNzw1B6Ax6wgrE63FrzSx1PSpuhaOCxbb3q3FNWxT1xZKNPU4YRjC8RgmYH8GCmHSmFMbFJW6WA5waMmc+yn8e2t3wDRKdgBksbyDk7dD3/NUtZhJ513nI6bcRgH2/wZFIr6B477+G/epgYovs04h/IMMoo2dB1MTSoKLjbo7cFG3QFHweVljSw6tbq//YiampTXWol2mJdJbYIC37tqVzk5JDihuBz+mjDxR/0VRG8cmBHj3YejiEmtI0TjE4V418UnIBHBsrvuul3xYxfOuZeKVFkK7JIRGW5XNftMEX6froQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=thorsis.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvaX2394ffbKw2rH+V2p2gN+nF/9eTj95gVaZ1EOwus=; b=gn6IgjxcVtaHOYeJkpfdeh5H091plVzNsa4a69e5M0EZi4HDB4sh7o27nVgJH3ukoBX1sA7Q9xrRUBusWK6pAkVRpNZAp2Tv2eOCIG8AXjL1n/3yghh0RlgoYqdAWie8rzcZIzh/Q7/T7Kp8PxCUQBgtJmeRWGr03zuRKHg5jLg= Received: from MW4P222CA0021.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::26) by PH7PR12MB7163.namprd12.prod.outlook.com (2603:10b6:510:202::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 6 Oct 2022 14:44:51 +0000 Received: from CO1NAM11FT029.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::f9) by MW4P222CA0021.outlook.office365.com (2603:10b6:303:114::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36 via Frontend Transport; Thu, 6 Oct 2022 14:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT029.mail.protection.outlook.com (10.13.174.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Thu, 6 Oct 2022 14:44:50 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 6 Oct 2022 09:44:48 -0500 Message-ID: <5f7a9b48-8cb0-795f-464d-d91f87f69905@amd.com> Date: Thu, 6 Oct 2022 16:44:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG Content-Language: en-US To: Alexander Dahl , References: <20221005114421.24340-1-ada@thorsis.com> From: Michal Simek In-Reply-To: <20221005114421.24340-1-ada@thorsis.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT029:EE_|PH7PR12MB7163:EE_ X-MS-Office365-Filtering-Correlation-Id: 944b03b6-3463-4d9e-c8d8-08daa7a952f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5EMjqBbYfUI728I1i9XEOOZeGMoWZpO1aYoyLCd9YMQ6jxXWo2Vvmdlrrg/rFpOk+h75EbYAIkp95svTDMWIByrCTOpxeqzD7B9lKGqWk5Gciq1fZEdmFziAORR/QtRp0fcjVv2r3rGkJRXSJUcfd1EAGXqAThW8KmA0cgK1cuRrOb/Ij/TOtOfyyO+QZJ2fmUg577KMiwG0s4uZWMwo4W7VEkSxZFJ+qhHWhcnwUSvEw8aw4JLwXcaztMToybevxlOU9hvWsaWpopniB+bOIJBe97Jrbx3PCn5IJ/8WtAT1M191I0C9e3sIyIHJzugO+4zZEb+AAO0JUgwvtwwD/U4MComcH2RAFBldmfR+pIs7xzKd9jAOn1rTWgBFekRGJB5HsDGy3+j4Tfnz6p/34r64jII2+PrzHQGYNo1SEvSOaa9CItoiDM5rIVMPoxtT2FS3vOumuR6M9ub4Mps/DGxaUgXsA+c1Rx+Ij9n03/371eQPI3ioIk+puJWjKBlQvbSK+BgdxQyZc9SXSooPQBlzrGS2isy6xAVsDcDdQrFcXE3n06nUl3PSRPPbjeCsWed11iwG2IhmLS1grtVpN3+1SyHcE8y3hh0mGNNSEUN6E6TFD+tntJFFFdJyrbmxO/SwokGZKuRvRQvQF33Tyonf3fzQd/y82Z3ghfZqQ2bnna9Eh0aJPs+hLlIQLuA6KdiuN9Fw43urnFSObkbaWMX0S/mQpV3OFW5Tnv9JwYpRGHkMQwGo1DdgMT2tunZOmwCstqUlv9zyY4SXLkW+ubpobxr1kgaYIsPoocfdJ2gLjT0jZSixZxwSUCk1WiI/kxCDfV2oQQbEJpiJCz+TQJ8o5WqoWsaqEG8Xc2SsSiA= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(83380400001)(186003)(16526019)(336012)(426003)(47076005)(356005)(81166007)(31696002)(86362001)(82310400005)(36860700001)(82740400003)(41300700001)(8936002)(5660300002)(316002)(16576012)(53546011)(70206006)(40480700001)(8676002)(44832011)(70586007)(110136005)(40460700003)(26005)(2616005)(966005)(2906002)(6666004)(478600001)(36756003)(31686004)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 14:44:50.7295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 944b03b6-3463-4d9e-c8d8-08daa7a952f0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT029.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7163 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On 10/5/22 13:44, Alexander Dahl wrote: > Hei hei, > > while working on FPGA support for a new device I discovered debug > logging in some FPGA drivers is still done as in the old days. Bring > that to what I thougt would be the currently preferred approach. > > Notes: Adding those Kconfig symbols in patch 3 is just to be able to > build those two old drivers. > > All drivers touched were build tested with sandbox_defconfig and GCC 8 > on Debian GNU/Linux 10 (buster). > > Lines with other possibly questionable output were not touched, only > what seemed to be designated debug output, and only for FPGA drivers > having that ancient FPGA_DEBUG / PRINTF macros, so there's room for > future improvements. > > Changelog: > > v2 -> v3: > - Patch introducing FPGA uclass was completely reworked, sent > independently from this series, and applied already, thus removed > - Because requiring that new FPGA uclass changes, rebased on Michal's > microblaze branch '20221005' > - Removed '"%s …", __func__' and '"%d …", __line__' from log messages, > because log framework can add those (enabled by CONFIG_LOGF_FUNC and > CONFIG_LOGF_LINE) > > v1 -> v2: > - Rebased on master > - Added patch to introduce new FPGA uclass in front of the other patches > - Use that new uclass as log category > - Slightly reworded cover letter > > Greets > Alex > > Cc: Michal Simek > > Alexander Dahl (7): > fpga: altera: Use logging feature instead of FPGA_DEBUG > fpga: cyclon2: Use logging feature instead of FPGA_DEBUG > fpga: Add missing Kconfig symbols for old FPGA drivers > fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG > fpga: spartan2: Use logging feature instead of FPGA_DEBUG > fpga: spartan3: Use logging feature instead of FPGA_DEBUG > fpga: virtex2: Use logging feature instead of FPGA_DEBUG > > drivers/fpga/ACEX1K.c | 37 +++++++++---------- > drivers/fpga/Kconfig | 12 +++++++ > drivers/fpga/altera.c | 11 +++--- > drivers/fpga/cyclon2.c | 38 +++++++++----------- > drivers/fpga/spartan2.c | 80 +++++++++++++++++++---------------------- > drivers/fpga/spartan3.c | 80 +++++++++++++++++++---------------------- > drivers/fpga/virtex2.c | 69 ++++++++++++++++------------------- > 7 files changed, 152 insertions(+), 175 deletions(-) I pushed it to CI loop and got failure. https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/jobs/508906 Building current source for 136 boards (64 threads, 1 job per thread) m68k: + astro_mcf5373l +In file included from include/linux/printk.h:4, + from include/common.h:20, + from drivers/fpga/spartan3.c:14: +drivers/fpga/spartan3.c: In function 'spartan3_sp_load': +drivers/fpga/spartan3.c:112:27: error: too many arguments for format [-Werror=format-extra-args] + 112 | log_debug("Function Table:\n" + | ^~~~~~~~~~~~~~~~~~~ +include/log.h:220:24: note: in definition of macro 'log' + 220 | printf(_fmt, ##_args); \ + | ^~~~ +drivers/fpga/spartan3.c:112:17: note: in expansion of macro 'log_debug' + | ^~~~~~~~~ +cc1: all warnings being treated as errors +make[3]: *** [scripts/Makefile.build:258: drivers/fpga/spartan3.o] Error 1 +make[2]: *** [scripts/Makefile.build:398: drivers/fpga] Error 2 +make[1]: *** [Makefile:1883: drivers] Error 2 Please fix it up. Thanks, Michal