Re: [PATCH v2 15/30] ram: rockchip: Add basic support for RK3528

[Kever Yang <kever.yang@rock-chips.com>]

On 2025/4/8 06:46, Jonas Karlman wrote:
> Add support for reading DRAM size information from PMUGRF os_reg18 reg.
>
> Compared to most Rockchip SoCs the RK3528 use os_reg18 for DRAM info,
> instead of os_reg2.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> v2: No change
> ---
>   arch/arm/mach-rockchip/sdram.c      |  3 ++-
>   drivers/ram/rockchip/Makefile       |  1 +
>   drivers/ram/rockchip/sdram_rk3528.c | 33 +++++++++++++++++++++++++++++
>   3 files changed, 36 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/ram/rockchip/sdram_rk3528.c
>
> diff --git a/arch/arm/mach-rockchip/sdram.c b/arch/arm/mach-rockchip/sdram.c
> index 0bdda77a7926..91a6606d461f 100644
> --- a/arch/arm/mach-rockchip/sdram.c
> +++ b/arch/arm/mach-rockchip/sdram.c
> @@ -110,7 +110,8 @@ static int rockchip_dram_init_banksize(void)
>   	u8 i, j;
>   
>   	if (!IS_ENABLED(CONFIG_ROCKCHIP_RK3588) &&
> -	    !IS_ENABLED(CONFIG_ROCKCHIP_RK3568))
> +	    !IS_ENABLED(CONFIG_ROCKCHIP_RK3568) &&
> +	    !IS_ENABLED(CONFIG_ROCKCHIP_RK3528))
>   		return -ENOTSUPP;
>   
>   	if (!IS_ENABLED(CONFIG_ROCKCHIP_EXTERNAL_TPL))
> diff --git a/drivers/ram/rockchip/Makefile b/drivers/ram/rockchip/Makefile
> index 36dc0500dab5..f222cc99f1e4 100644
> --- a/drivers/ram/rockchip/Makefile
> +++ b/drivers/ram/rockchip/Makefile
> @@ -13,6 +13,7 @@ obj-$(CONFIG_ROCKCHIP_RK3288) = sdram_rk3288.o
>   obj-$(CONFIG_ROCKCHIP_RK3308) = sdram_rk3308.o
>   obj-$(CONFIG_ROCKCHIP_RK3328) = sdram_rk3328.o sdram_pctl_px30.o sdram_phy_px30.o
>   obj-$(CONFIG_ROCKCHIP_RK3399) += sdram_rk3399.o
> +obj-$(CONFIG_ROCKCHIP_RK3528) += sdram_rk3528.o
>   obj-$(CONFIG_ROCKCHIP_RK3568) += sdram_rk3568.o
>   obj-$(CONFIG_ROCKCHIP_RK3588) += sdram_rk3588.o
>   obj-$(CONFIG_ROCKCHIP_RV1126) += sdram_rv1126.o sdram_pctl_px30.o
> diff --git a/drivers/ram/rockchip/sdram_rk3528.c b/drivers/ram/rockchip/sdram_rk3528.c
> new file mode 100644
> index 000000000000..89d325bea667
> --- /dev/null
> +++ b/drivers/ram/rockchip/sdram_rk3528.c
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright Contributors to the U-Boot project.
> +
> +#include <dm.h>
> +#include <ram.h>
> +#include <asm/arch-rockchip/sdram.h>
> +
> +#define PMUGRF_BASE			0xff370000
> +#define OS_REG18_REG			0x248
> +
> +static int rk3528_dmc_get_info(struct udevice *dev, struct ram_info *info)
> +{
> +	info->base = CFG_SYS_SDRAM_BASE;
> +	info->size = rockchip_sdram_size(PMUGRF_BASE + OS_REG18_REG);
> +
> +	return 0;
> +}
> +
> +static struct ram_ops rk3528_dmc_ops = {
> +	.get_info = rk3528_dmc_get_info,
> +};
> +
> +static const struct udevice_id rk3528_dmc_ids[] = {
> +	{ .compatible = "rockchip,rk3528-dmc" },
> +	{ }
> +};
> +
> +U_BOOT_DRIVER(rockchip_rk3528_dmc) = {
> +	.name = "rockchip_rk3528_dmc",
> +	.id = UCLASS_RAM,
> +	.of_match = rk3528_dmc_ids,
> +	.ops = &rk3528_dmc_ops,
> +};