From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6FF0C05027 for ; Thu, 2 Feb 2023 05:13:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3AE5985E90; Thu, 2 Feb 2023 06:13:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B41B885E8D; Thu, 2 Feb 2023 06:13:45 +0100 (CET) Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by phobos.denx.de (Postfix) with ESMTP id 595F785E90 for ; Thu, 2 Feb 2023 06:13:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hayashi.kunihiko@socionext.com Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 02 Feb 2023 14:13:39 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id B46BC2058B4F; Thu, 2 Feb 2023 14:13:39 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 2 Feb 2023 14:13:35 +0900 Received: from [10.212.156.77] (unknown [10.212.156.77]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 4D5933D57; Thu, 2 Feb 2023 14:13:39 +0900 (JST) Message-ID: <5fecc5de-97c8-7979-7db7-da665d899b59@socionext.com> Date: Thu, 2 Feb 2023 14:13:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 10/12] ARM: dts: uniphier: Fix node names and missing reg property in USB glue node To: Marek Vasut , Michal Simek , Sean Anderson , Angus Ainslie , Lukasz Majewski , T Karthik Reddy , Jan Kiszka Cc: u-boot@lists.denx.de References: <20230201011325.10679-1-hayashi.kunihiko@socionext.com> <20230201011325.10679-11-hayashi.kunihiko@socionext.com> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On 2023/02/02 6:55, Marek Vasut wrote: > On 2/1/23 02:13, Kunihiko Hayashi wrote: >> The node name should follow the generic name list in DT specification. >> This moves "reset" to "reset-controller", "hs-phy" and "ss-phy" to "phy" >> in the USB glue node. >> >> And the node should have reg property to define the register region. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> arch/arm/dts/uniphier-ld20.dtsi | 15 ++++++++------- >> arch/arm/dts/uniphier-pro4.dtsi | 7 ++++--- >> arch/arm/dts/uniphier-pro5.dtsi | 15 ++++++++------- >> arch/arm/dts/uniphier-pxs2.dtsi | 20 +++++++++++--------- >> arch/arm/dts/uniphier-pxs3.dtsi | 20 +++++++++++--------- >> 5 files changed, 42 insertions(+), 35 deletions(-) > > I don't mind this patch, but would it make sense to later, in a separate > patch, synchronize the .dtsi with Linux kernel fully ? I see. I also think I should to synchronize the devicetree with Linux, so I'll separate this patch from this series in the next. Thank you, --- Best Regards Kunihiko Hayashi